Closed Bug 1115199 Opened 7 years ago Closed 7 years ago

firefoxtree overrides default push behaviour for regular repositories

Categories

(Developer Services :: Mercurial: firefoxtree, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mossop, Unassigned)

Details

Attachments

(1 file, 1 obsolete file)

I'd like to push the entire contents of my repo to my personal bitbucket repo, but firefoxtree overrides the push behaviour to only push the current head:

$ hg push ssh://hg@bitbucket.org/mossop/gecko
pushing to ssh://hg@bitbucket.org/mossop/gecko
no revisions specified to push; using . to avoid pushing multiple heads
searching for changes
no changes found
Yes, currently we change the default push behavior when working with any local repository that is a Firefox repository. It is perfectly reasonable to change this so the behavior only changes if talking to a canonical Firefox remote repo. https://hg.mozilla.org/hgcustom/version-control-tools/file/56cf093e516b/hgext/firefoxtree/__init__.py#l155
On IRC, Mossop suggested he was doing this from a script.  KWierso suggested disabling firefoxtree, and I see http://www.kibibu.com/2014/02/disable-extensions-from-the-mercurial-command-line/ recommends:

hg --config extensions.firefoxtree=! ...
(In reply to Gregory Szorc [:gps] from comment #1)
> Yes, currently we change the default push behavior when working with any
> local repository that is a Firefox repository. It is perfectly reasonable to
> change this so the behavior only changes if talking to a canonical Firefox
> remote repo.
> https://hg.mozilla.org/hgcustom/version-control-tools/file/56cf093e516b/
> hgext/firefoxtree/__init__.py#l155

The docs claim this already, hence my confusion. "firefoxtree automatically changes hg push to behave like hg push -r . when pushing to a Firefox repository"
Attached file MozReview Request: bz://1115199/gps (obsolete) —
Attachment #8541014 - Flags: review?(mh+mozilla)
/r/1701 - firefoxtree: allow pushing multiple heads to non-canonical repos (bug 1115199)

Pull down this commit:

hg pull review -r 0eaad48dd1ad0336cc11af78b4086a8db4ea1419
https://reviewboard.mozilla.org/r/1699/#review1081

::: hgext/firefoxtree/tests/test-prevent-push-multiple-heads.t
(Diff revision 1)
> +  $ hg push --force -r 0:tip ssh://user@dummy/$TESTTMP/root/non-canonical

I guess you didn't mean to use -r 0:tip here...
/r/1701 - firefoxtree: allow pushing multiple heads to non-canonical repos (bug 1115199)

Pull down this commit:

hg pull review -r 00aad1841226295662d74ea38581d9ed25d0d768
Attachment #8541014 - Flags: review?(mh+mozilla) → review+
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Attachment #8541014 - Attachment is obsolete: true
Attachment #8618971 - Flags: review+
You need to log in before you can comment on or make changes to this bug.