1115214 - [Fetch] GlobalFetch.fetch() and read body methods make crash for Maple

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Arkadiusz Michalski (Spirit)]

Attachment: This file will not crash Maple (empty string)

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:34.0) Gecko/20100101 Firefox/34.0
Build ID: 20141125180439

Steps to reproduce:

Continuation of https://bugzilla.mozilla.org/show_bug.cgi?id=1109574#c4

I noticed that using fetch() method in Maple version make some crash. This happen when I use some url (even in the same origin) and try read body. I don't get crash when using exactly the same page where run code (via passing empty string). You can check this through attached file. 

This problem is more painful for local file (file://) where passing empty string will always crash browser.

Comment 1

[Arkadiusz Michalski (Spirit)]

Attachment: This file will crash Maple (different origins)

Comment 2

[Ben Kelly [:bkelly, not reviewing]]

Mikhail, can you take a look?

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: Fetch API: Always consume body asynchronously

Thanks for pointing this out!
The problem was that on the main thread, a response with no body would go through the consume body steps synchronously, leading to mConsumePromise being null by the time it was returned from ConsumeBody().

Comment 4

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Comment on attachment 8541100 [details] [diff] [review]
Fetch API: Always consume body asynchronously

Andrea, this is based of the Basic HTTP fetch patch.

Comment 5

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/43843a529109

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/43843a529109