Closed Bug 1115231 Opened 5 years ago Closed 3 years ago

During a timeout in the simple push, the _requestQueue is not erased.

Categories

(Core :: DOM: Push Notifications, defect, minor)

Other
FreeBSD
defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla50
Tracking Status
firefox50 --- fixed

People

(Reporter: iwahashi.kentarou.dev, Unassigned)

Details

Attachments

(1 file)

I found a behavior, such as the following. I think bug.
- During a timeout in the simple push, the _requestQueue is not erased.
I will attach a patch of draft.
Hi Iwahashi, thanks for the patch. Let's have peer to review it.
Attachment #8541042 - Flags: review?(nsm.nikhil)
Thanks for the patch! Sorry this sat in the queue for so long.

We're replacing Simple Push with Service Workers + Web Push on Desktop, but FxOS still uses it. I'll go ahead and land this. Better late than never. :-)
Pushed by kcambridge@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/eb00b57e9cd0
Clear timed out Simple Push requests. r=nsm
https://hg.mozilla.org/mozilla-central/rev/eb00b57e9cd0
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla50
You need to log in before you can comment on or make changes to this bug.