[Stingray][System] system app tries to focus a non-focusable element

RESOLVED FIXED

Status

Firefox OS
General
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: johnhu, Assigned: rexboy)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [ft:conndevices] [Stingray-Branch] [picked 1/29])

Attachments

(1 attachment)

We got the same issue in Stingray project.

+++ This bug was initially created as a clone of Bug #1115277 +++

Few modules try to focus a non-focusable, tabIndex=-1, element while they show up.

Like:

[1] https://github.com/mozilla-b2g/gaia/blob/d55d1d5f39bd338ab2d298823aab1121e3d73fef/apps/system/js/app_modal_dialog.js#L226
[2] https://github.com/mozilla-b2g/gaia/blob/d55d1d5f39bd338ab2d298823aab1121e3d73fef/apps/system/js/modal_dialog.js#L213

For those cases, we should focus the first focusable element, like ok button or cancel button.
Blocks: 1115294
No longer blocks: 1115294

Updated

4 years ago
Assignee: nobody → 938.daisuke

Comment 1

4 years ago
Kusaba-san, please verify if this happens on your side, if not, feel free to close it. If yes, we may need your help to fix it. Thank you.

Updated

4 years ago
Flags: needinfo?(938.daisuke)
Whiteboard: [ft:conndevices]

Comment 2

4 years ago
Rex, assign this bug to you. Please separate your work on bug 1105981 and fix ModalDialog focus issue here. Thanks
Assignee: 938.daisuke → rexboy
Flags: needinfo?(rexboy)

Updated

3 years ago
Whiteboard: [ft:conndevices] → [ft:conndevices] [Stingray-Branch]

Updated

3 years ago
Whiteboard: [ft:conndevices] [Stingray-Branch] → [ft:conndevices]
Created attachment 8552949 [details] [review]
Patch

This PR contains two patches. please review the commit just for this bug.
Flags: needinfo?(rexboy)
Attachment #8552949 - Flags: review?(im)
Comment on attachment 8552949 [details] [review]
Patch

For smart-system part, it looks ok. But please update the code based on our discussion at this morning. I had put some comments at PR. Please check them, too.
Attachment #8552949 - Flags: review?(im) → review+
Blocks: 1125036
Blocks: 1125074

Comment 5

3 years ago
Hi Rex, any update for the Comment 4?
Flags: needinfo?(938.daisuke) → needinfo?(rexboy)
I've already updated it, but Gaia test keeps failing since yesterday. I'll land it once tests becomes green.
Flags: needinfo?(rexboy)

Updated

3 years ago
Whiteboard: [ft:conndevices] → [ft:conndevices] [Stingray-Branch]
https://github.com/mozilla-b2g/gaia/commit/0cd74b1e29c3d7a6dbf3ceba9ea6ac42275257cb
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED

Updated

3 years ago
Whiteboard: [ft:conndevices] [Stingray-Branch] → [ft:conndevices] [Stingray-Branch] [picked 1/29]
You need to log in before you can comment on or make changes to this bug.