1115293 - Remove deprecated SpiderMonkey language extensions from about:permissions

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Chris Peterson [:cpeterson]]

Attachment: fix-about-permissions.patch

let blocks and for-each-in loops are nonstandard SpiderMonkey language extensions and should be replaced with standard JS. This patch fixes following JS warnings from opening about:permissions.

Note that the patch I've submitted ignores whitespace to make the diff easier to read (because removing the let blocks unindents a lot of otheriwse unchanged code). My local patch has proper indentation. :)

JavaScript warning: chrome://browser/content/preferences/aboutPermissions.js, line 572: JavaScript 1.7's let blocks are deprecated
and `for each`

JavaScript warning: resource://gre/modules/ForgetAboutSite.jsm, line 52: JavaScript 1.7's let blocks are deprecated
JavaScript warning: resource://gre/modules/ForgetAboutSite.jsm, line 65: JavaScript 1.7's let blocks are deprecated
JavaScript warning: resource://gre/modules/ForgetAboutSite.jsm, line 76: JavaScript 1.7's let blocks are deprecated
JavaScript warning: resource://gre/modules/ForgetAboutSite.jsm, line 87: JavaScript 1.7's let blocks are deprecated
JavaScript strict warning: resource://gre/modules/ForgetAboutSite.jsm, line 128: SyntaxError: in strict mode code, functions may be declared only at top level or immediately within another function
JavaScript warning: resource://gre/modules/ForgetAboutSite.jsm, line 116: JavaScript 1.7's let blocks are deprecated
JavaScript warning: resource://gre/modules/ForgetAboutSite.jsm, line 164: JavaScript 1.7's let blocks are deprecated
JavaScript warning: resource://gre/modules/ForgetAboutSite.jsm, line 185: JavaScript 1.7's let blocks are deprecated
JavaScript warning: resource://gre/modules/ForgetAboutSite.jsm, line 197: JavaScript 1.7's let blocks are deprecated

Comment 1

[Chris Peterson [:cpeterson]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9096b9b4aa73

Comment 2

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/9096b9b4aa73