All users were logged out of Bugzilla on October 13th, 2018

Including Upper Sorbian (hsb) and Lower Sorbian (dsb) locales on Thunderbird

RESOLVED FIXED in Thunderbird 37.0

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: milupo, Unassigned)

Tracking

Trunk
Thunderbird 37.0
x86
Windows XP

Thunderbird Tracking Flags

(thunderbird38+ fixed)

Details

Comment hidden (empty)
(Reporter)

Comment 1

4 years ago
Please include the locales hsb and dsb on Thunderbird. Thunderbird has been translated into both languages for a long time on mozilla.locamotion.org.
(Reporter)

Updated

4 years ago
Component: hsb / Upper Sorbian → Mail Window Front End
Product: Mozilla Localizations → Thunderbird
Target Milestone: --- → Thunderbird 34.0
Version: unspecified → Trunk
Flags: needinfo?(standard8)
(Reporter)

Comment 2

4 years ago
When the locales are included that Thunderbird builds can be created?

Comment 3

4 years ago
Setting tracking-thunderbird38 so that we make sure we decide on this prior to Thunderbird 38.
tracking-thunderbird38: --- → ?
(Reporter)

Comment 4

4 years ago
Thank you, Kent.
Hi Michael, I've just reviewed both the dsb (rev ced6b067225c) & hsb (rev 333ac2fc0af0) locales.

Generally they look fine, however they are missing some files.

For hsb:

  all-l10n.js
  chrome/messenger-region/region.properties
  searchplugins/list.txt

For dsb:

  all-l10n.js
  chrome/messenger-region/region.properties
  searchplugins/list.txt

dsb also has an error:

  chrome/messenger/messenger.properties
        ERROR: Double ordered argument 1 at line 397, column 53 for biffNotification_messages

For the list.txt files, I'd suggest just using the same ones as en-US to begin with. You probably want to do the same with the default engines list in messenger.properties.

We can deal with locale specific search engines in a follow-up bug later.


If you can fix those issues, then I think we can go ahead and the locales. Thanks.
tracking-thunderbird38: ? → +
Component: Mail Window Front End → Build Config
Flags: needinfo?(standard8) → needinfo?(milupo)
(Reporter)

Comment 6

4 years ago
Hi Mark,

thank you for your reply.

AFAIK only two strings are in file all-10.js - this for the general.useragent.locale and this for the spellchecker (both: hsb resp. dsb)

For the wrong dsb string in messenger.properties I had to know if I can use the Mozilla plural rule in this string. For dsb I used the plural rule and for hsb I did not use it. It seems that there is possible only one plural form. Shall i reduce the dsb plural forms?

Regarding to searchplugins: I don't know which search engines TB is using. But, in fact, there is only one specific search engine for Sorbian languages: This for the Wikipedia. The item for the Wikipedia search engine should point to hsb.wikipedia.org (Upper Sorbian WP) resp. dsb.wikipedia.org (Lower Sorbian WP). For all other search engines I'd prefer German as fallback language.

Regards

Michael
Flags: needinfo?(milupo)
(In reply to Michael Wolf from comment #6)
> AFAIK only two strings are in file all-10.js - this for the
> general.useragent.locale and this for the spellchecker (both: hsb resp. dsb)

Yes, please include them anyway, just like with the other locales:

http://mxr.mozilla.org/l10n-mozilla-aurora/search?string=general.useragent.locale&find=mail%2F.*all&findi=&filter=^[^\0]*%24&hitlimit=&tree=l10n-mozilla-aurora

> For the wrong dsb string in messenger.properties I had to know if I can use
> the Mozilla plural rule in this string. For dsb I used the plural rule and
> for hsb I did not use it. It seems that there is possible only one plural
> form. Shall i reduce the dsb plural forms?

Unfortunately biffNotification_messages doesn't support plural forms at the moment - see bug 500403. So you need to reduce it to just one instance that fits best.

> Regarding to searchplugins: I don't know which search engines TB is using.
> But, in fact, there is only one specific search engine for Sorbian
> languages: This for the Wikipedia. The item for the Wikipedia search engine
> should point to hsb.wikipedia.org (Upper Sorbian WP) resp. dsb.wikipedia.org
> (Lower Sorbian WP). For all other search engines I'd prefer German as
> fallback language.

If you include the standard list.txt from en-US for now, that means we'll be able to start getting your locale on the dashboard and builds out for testing.

We can then handle the search engine specifics in another bug - the search engine is not primary UI in Thunderbird so it won't hurt for a couple of weeks (search engine details need additional work, so I'm concentrating on getting builds and the initial infrastructure set up for you).
(Reporter)

Comment 8

4 years ago
I have access to Pootle only, not to all-l10n.js and list.txt.

The German search plugins are (from Aurora 37.0a2 build):

amazondotcom-de.xml
bing.xml
ebay-de.xml
twitter-de.xml
wikipedia-de.xml
yahoo-de.xml

I'd like to have them escept for the wikipedia plugin. There should be wikipedia-hsb.xml resp. wikipedia-dsb.xml. But if you need more time, you can use the en-US search plugin for the time being.
Hi Michael,

I pushed some additions to add the missing files. I've also now done the work to enable hsb and dsb on the dashboard. They should appear in your team sections within an hour or two:

https://l10n.mozilla.org/teams/dsb
https://l10n.mozilla.org/teams/hsb

I've filed bug 1134646 for the search-engine follow-up.

I'll also get the nightly builds added to the list for Aurora - these might take a couple of days to show up.

Just for me reference, the change for the dashboard was this one:

https://hg.mozilla.org/releases/comm-aurora/rev/b7895b137065
Oh, also, it'll show up on Beta and be available for sign-off after Monday.

Please remember to sign off each cycle if possible (or whenever you make a set of changes).
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
(Reporter)

Comment 11

4 years ago
Thank you for all, Mark.

Updated

4 years ago
status-thunderbird38: --- → fixed
Target Milestone: Thunderbird 34.0 → Thunderbird 37.0
You need to log in before you can comment on or make changes to this bug.