Closed Bug 1115365 Opened 5 years ago Closed 5 years ago

Hello "Import" button seems to assume everyone uses GMail

Categories

(Hello (Loop) :: Client, defect, trivial)

defect
Not set
trivial

Tracking

(firefox40 verified)

VERIFIED FIXED
mozilla40
Tracking Status
firefox40 --- verified

People

(Reporter: SimonSapin, Assigned: cedric.raudin, Mentored)

Details

(Whiteboard: [good first bug][lang=js])

Attachments

(1 file)

When clicking the "Import" button, I get an error message from Google as in bug 1106854. The reason is likely that of bug 1106854. (I use Archlinux’s Firefox package).

But regardless of OAuth being properly set up or not, why is this button going to Google in the first place? I don’t use GMail as my primary email account, and I’m sure many other users don’t either. Importing from GMail can certainly be an option, but it shouldn’t be an assumption.
Other import types are planned - GMail was the easiest and quickest one for us to implement as a starter (we already had code for it).
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 972000
I disagree on this being a duplicate of bug 972000. I personally don’t care all that much about importing from non-GMail, or importing contacts at all. I was just surprised by the way this is presented to users: a button labeled only "Import" goes straight to GMail, as if we were pretending that GMail is the only email/contact provider that ever existed.

So let’s make this bug a request to (until other import sources are added) change the button label to "Import from GMail".
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
Severity: normal → trivial
OS: Linux → All
Hardware: x86_64 → All
Sevaan: Do we want to make the change suggested in comment 2 for now? (I'm thinking a low-priority good first bug)
Flags: needinfo?(sfranks)
and it should probably just be "Import from Google"
Yes, this sounds like a good first bug.

Possibly silly question: Is it possible to hide the button completely if, say, we don't detect the existence of a GMail cookie?
Flags: needinfo?(sfranks)
We could block on cookie (I suspect, with a bit of work), but that would stop people importing contacts who, for example, use external mail clients for gmail (like I do ;-) ).

I'm also thinking this is a temporary change until we get time to add some more providers in.
Flags: needinfo?(sfranks)
Sounds good. Was just curious.
Flags: needinfo?(sfranks)
Adding as a good first bug.

There's some additional background info for Loop development here, you'll need the jsx parts to fix this:

https://wiki.mozilla.org/Loop/Development

What needs doing: This is a simple string change. The "Import" string in the contacts panel, when you're signed into Hello, needs changing to "Import from Google". Here's the code references:

http://mxr.mozilla.org/mozilla-central/search?string=import_contacts_button&find=&findi=&filter=^[^\0]*%24&hitlimit=&tree=mozilla-central

When changing this, the string id needs to change from "import_contacts_button" to "import_contacts_button2" as an indication to l10n that the string is different now.
Mentor: standard8
Status: REOPENED → NEW
Whiteboard: [good first bug][lang=js]
Assignee: nobody → cedric.raudin
Hi, I'm wondering if the patch is prepared (but not attached yet)? The bug was assigned a week ago. If the assignee do not have time for solving the bug than I am interested in taking it over :) (please, do not get me wrong, I do not want to push anyone. As a beginner here I just lurking for simple bug opportunities to improve myself ;) )
Hi,

I am going to make it pretty soon. Sorry :) Good luck in your searches (http://www.joshmatthews.net/bugsahoy/ maybe this can help you).
Attachment #8599555 - Flags: review?(standard8)
Comment on attachment 8599555 [details] [diff] [review]
bug-1115365-fix.patch

Review of attachment 8599555 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great, thanks for the patch.
Attachment #8599555 - Flags: review?(standard8) → review+
I'll land this a bit later today.
https://hg.mozilla.org/mozilla-central/rev/08958b9a714e
Status: NEW → RESOLVED
Closed: 5 years ago5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla40
I did a quick check on the latest Firefox 40 Beta 4 (BuildID=20150713153304) on Win 7 x64, Mac OS X 10.9.5 and Ubuntu 12.04 x86, and the button now correctly says "Import from Google".
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.