1115388 - MSimdValueX4 and similar (Splat?) are not valid Float32 consumers.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Nicolas B. Pierron [:nbp]]

As AsmJS does not run the apply type phase which is done in Ion, we never needed that before.  Now that we expect to run the Apply type phase, we have to flag all these MSimd instructions as valid Float32 consumer when the MIRType of the Simd instruction implies that we accept Float32 input(s).

Comment 1

[Nicolas B. Pierron [:nbp]]

Attachment: Make Simd instructions, accepting Float32 operands, valid Float32 consumers.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Comment on attachment 8542167 [details] [diff] [review]
Make Simd instructions, accepting Float32 operands, valid Float32 consumers.

Review of attachment 8542167 [details] [diff] [review]:
-----------------------------------------------------------------

Simple and easy, thanks.

::: js/src/jit/IonTypes.h
@@ +565,5 @@
>  static inline unsigned
>  SimdTypeToLength(MIRType type)
>  {
>      MOZ_ASSERT(IsSimdType(type));
> +    return VectorSize(type);

Ha nice, I didn't know these two functions. However, this change is unrelated, please make a different patch moving the assertions + comments and renaming VectorSize to SimdTypeToLength / ElementType to SimdTypeToScalarType.

@@ +572,5 @@
>  static inline MIRType
>  SimdTypeToScalarType(MIRType type)
>  {
>      MOZ_ASSERT(IsSimdType(type));
> +    return ElementType(type);

see above

Comment 3

[Nicolas B. Pierron [:nbp]]

I divided the patch in 2 parts, as requested, the first one being about adding the canConsumeFloat32 methods, and the second being about inlining the ElementType and VectorSize inside the Simd functions.

https://hg.mozilla.org/integration/mozilla-inbound/rev/d8a111f0fb64
https://hg.mozilla.org/integration/mozilla-inbound/rev/94a046dfcb49

Comment 4

[Carsten Book [:Tomcat]]

sorry had to back this out in https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=bbb0b9dffd36 for bustages across platforms like:

https://treeherder.mozilla.org/logviewer.html#?job_id=4999847&repo=mozilla-inbound

Comment 5

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/projects/cypress/rev/8380f052db41
https://hg.mozilla.org/projects/cypress/rev/0d28603f938a

Comment 6

[Nicolas B. Pierron [:nbp]]

(fixed after back out) https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=c0e5f1d32261

https://hg.mozilla.org/integration/mozilla-inbound/rev/287d56de1d62
https://hg.mozilla.org/integration/mozilla-inbound/rev/5b4b340109fc

Comment 7

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/287d56de1d62
https://hg.mozilla.org/mozilla-central/rev/5b4b340109fc