1115398 - Enable the windows module tests on travis

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

These tests were disabled for travis in https://github.com/mozilla/addon-sdk/pull/1748/files#diff-14

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1768

Comment 2

[Tomislav Jovanovic :zombie]

Comment on attachment 8541321 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1768

is this meant to be a semantically equivalent rewrite of tests (except for timeout/promise/yield)?

r+ if that's true, because i tried and failed to find any difference.

btw, i left a few nits in the comments.

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/98959229d08802ec3a4592271e793d244a4cb5a3
Bug 1115398 - Enable the windows module tests on travis a=me

https://github.com/mozilla/addon-sdk/commit/aa670192927c5520b447fcd83bee26322336baf5
Bug 1115398 rewrite the testActiveWindow window module test from test-windows.js

https://github.com/mozilla/addon-sdk/commit/0be02f637a0945494cc85da5d62f62ae8c880df8
Bug 1115398 removing an unnecessary use of isWindowPBSupported in test-firefox-windows.js

https://github.com/mozilla/addon-sdk/commit/1ec4dc39b9567b4a6ead0e79691131f6262168a8
Merge pull request #1768 from erikvold/1115398

Bug 1115398 - Enable the windows module tests on travis r=@zombie