Update sidebar tests to use generator functions

RESOLVED FIXED

Status

RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: evold, Assigned: evold)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

The sidebar tests are a little hard to read, using generator functions should improve this.
Blocks: 888774
Assignee: nobody → evold
Attachment #8541332 - Flags: review?(jsantell)
Blocks: 1118128
Comment on attachment 8541332 [details] [review]
Link to Github pull-request: https://github.com/mozilla/addon-sdk/pull/1770

Looks like something's weird with the history on that PR -- other than that r+
Attachment #8541332 - Flags: review?(jsantell) → review+

Comment 3

4 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/7e2bc3c85935a709cd99998ae5d5565c010cb7b5
Bug 1115430 - Update sidebar tests to use generator functions

https://github.com/mozilla/addon-sdk/commit/a364683c896c83d4d8d8c2b68c673958fcadcbfc
Bug 1115430 - Update sidebar tests to use generator functions

https://github.com/mozilla/addon-sdk/commit/e3638844193efde2e6ccc77d5d6e8135f344acc5
Bug 1115430 fixing some parts of the test-sidebar.js file which did not yield when they should have

https://github.com/mozilla/addon-sdk/commit/e47c7eb79a6428674c57081906c7e4b7eadc2506
Bug 1115430 - Update sidebar tests to use generator functions

https://github.com/mozilla/addon-sdk/commit/76a8c82455beea5b3d0d3e6f5ef5ac0f795b4af7
Merge pull request #1770 from erikvold/1115430

Bug 1115430 - Update sidebar tests to use generator functions r=jsantell
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.