If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Can't accept SDP with multiple a=fingerprint lines

RESOLVED FIXED in Firefox 39

Status

()

Core
WebRTC: Networking
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: mt, Assigned: mt)

Tracking

unspecified
mozilla39
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox39 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
On http://dxr.mozilla.org/mozilla-central/source/media/mtransport/transportlayerdtls.cpp#1053

s/!=/==/

Only one needs to match.
(Assignee)

Comment 1

3 years ago
Created attachment 8547836 [details]
MozReview Request: bz://1115483/mt
Attachment #8547836 - Flags: review?(ekr)
(Assignee)

Comment 2

3 years ago
/r/2369 - Bug 1115483 - Accepting a match on any a=fingerprint value

Pull down this commit:

hg pull review -r 855d718516bed3ddcbc9a379278fcef96ec27950
(Assignee)

Comment 3

3 years ago
https://treeherder.mozilla.org/ui/#/jobs?repo=try&revision=5d3ee0400eae

:ekr, thanks for having all the tests already in place :)
(Assignee)

Comment 4

3 years ago
ekr, would you mind?
Flags: needinfo?(ekr)

Updated

3 years ago
Attachment #8547836 - Flags: review?(ekr) → review+

Comment 5

3 years ago
Comment on attachment 8547836 [details]
MozReview Request: bz://1115483/mt

https://reviewboard.mozilla.org/r/2367/#review3721

Ship It!

Comment 6

3 years ago
Please coordinate this with Justin Uberti.
Flags: needinfo?(ekr)
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/8f99a6c6fe8f
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8f99a6c6fe8f
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
(Assignee)

Comment 9

2 years ago
Comment on attachment 8547836 [details]
MozReview Request: bz://1115483/mt
Attachment #8547836 - Attachment is obsolete: true
Attachment #8618977 - Flags: review+
(Assignee)

Comment 10

2 years ago
Created attachment 8618977 [details]
MozReview Request: Bug 1115483 - Accepting a match on any a=fingerprint value
You need to log in before you can comment on or make changes to this bug.