Closed Bug 1115494 Opened 6 years ago Closed 6 years ago

[RTL] Share activity menu icons are not right-alined

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

All
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-v2.2 verified)

VERIFIED FIXED
Tracking Status
b2g-v2.2 --- verified

People

(Reporter: nefzaoui, Assigned: nefzaoui)

References

Details

Attachments

(4 files)

The share activity menu icons are currently to the far left in RTL, however, they need to be right-alined.
Blocks: system-rtl
Attached image Bug Screenshot
How the bug looks like.
Assignee: nobody → nefzaoui
Status: NEW → ASSIGNED
Please review :)
Attachment #8541419 - Flags: ui-review?(swilkes)
Comment on attachment 8541415 [details] [review]
[PullReq] anefzaoui:bug-1115494 to mozilla-b2g:master

Small one, please review?
Thanks!
Attachment #8541415 - Flags: review?(dflanagan)
See Also: → 1115152
Comment on attachment 8541415 [details] [review]
[PullReq] anefzaoui:bug-1115494 to mozilla-b2g:master

I'm not an appropriate reviewer for this patch. mhenretty has reviewed one that touches this file recently, however, so maybe he could review or pass it on to someone appropriate.
Attachment #8541415 - Flags: review?(dflanagan) → review?(mhenretty)
Comment on attachment 8541419 [details]
Screenshot - Patch Applied

Looks good. Thanks, Ahmed. I apologize for the delay; I was off for the Christmas holiday with family. :)
Attachment #8541419 - Flags: ui-review?(swilkes) → ui-review+
Comment on attachment 8541415 [details] [review]
[PullReq] anefzaoui:bug-1115494 to mozilla-b2g:master

Code looks good, and works like a charm. Left one mega tiny nit on github, but r=me.
Attachment #8541415 - Flags: review?(mhenretty) → review+
Hey Michael,
Left you a comment on the PR, could you please let me know what do you think?
Thanks!
Flags: needinfo?(mhenretty)
Echoing github, sounds good to me.
Flags: needinfo?(mhenretty)
Thanks :)
Keywords: checkin-needed
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Note: Until bug 1095028 lands, the patch *must* have a review by a suggested reviewer. If you are the patch author, you can leave an additional R+ on the attachment for autolander to process it.
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Note: Until bug 1095028 lands, the patch *must* have a review by a suggested reviewer. If you are the patch author, you can leave an additional R+ on the attachment for autolander to process it.
Comment on attachment 8541415 [details] [review]
[PullReq] anefzaoui:bug-1115494 to mozilla-b2g:master

Throwing in my review stamp to appease Autolander. Not sure why it commented twice, should fix that..
Attachment #8541415 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Keywords: verifyme
Status: RESOLVED → VERIFIED
Keywords: verifyme
Attached image 2015-01-15-05-46-25.png
This issue does not exist on Flame 2.2
Gaia-Rev        7c5b27cad370db377b18a742d3f3fdb0070e899f
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/ce27f2692382
Build-ID        20150115002505
Version         37.0a2
Reproduce rate 0/5
You need to log in before you can comment on or make changes to this bug.