1115494 - [RTL] Share activity menu icons are not right-alined

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Ahmed Nefzaoui [:Nefzaoui]]

The share activity menu icons are currently to the far left in RTL, however, they need to be right-alined.

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] anefzaoui:bug-1115494 to mozilla-b2g:master

Comment 2

[Ahmed Nefzaoui [:Nefzaoui]]

Attachment: Bug Screenshot

How the bug looks like.

Comment 3

[Ahmed Nefzaoui [:Nefzaoui]]

Attachment: Screenshot - Patch Applied

Please review :)

Comment 4

[Ahmed Nefzaoui [:Nefzaoui]]

Comment on attachment 8541415 [details] [review]
[PullReq] anefzaoui:bug-1115494 to mozilla-b2g:master

Small one, please review?
Thanks!

Comment 5

[David Flanagan [:djf]]

Comment on attachment 8541415 [details] [review]
[PullReq] anefzaoui:bug-1115494 to mozilla-b2g:master

I'm not an appropriate reviewer for this patch. mhenretty has reviewed one that touches this file recently, however, so maybe he could review or pass it on to someone appropriate.

Comment 6

[Stephany Wilkes]

Comment on attachment 8541419 [details]
Screenshot - Patch Applied

Looks good. Thanks, Ahmed. I apologize for the delay; I was off for the Christmas holiday with family. :)

Comment 7

[Michael Henretty [:mikehenrty][:mhenretty]]

Comment on attachment 8541415 [details] [review]
[PullReq] anefzaoui:bug-1115494 to mozilla-b2g:master

Code looks good, and works like a charm. Left one mega tiny nit on github, but r=me.

Comment 8

[Ahmed Nefzaoui [:Nefzaoui]]

Hey Michael,
Left you a comment on the PR, could you please let me know what do you think?
Thanks!

Comment 9

[Michael Henretty [:mikehenrty][:mhenretty]]

Echoing github, sounds good to me.

Comment 10

[Ahmed Nefzaoui [:Nefzaoui]]

Thanks :)

Comment 11

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Note: Until bug 1095028 lands, the patch *must* have a review by a suggested reviewer. If you are the patch author, you can leave an additional R+ on the attachment for autolander to process it.

Comment 12

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Note: Until bug 1095028 lands, the patch *must* have a review by a suggested reviewer. If you are the patch author, you can leave an additional R+ on the attachment for autolander to process it.

Comment 13

[Kevin Grandon :kgrandon]

Comment on attachment 8541415 [details] [review]
[PullReq] anefzaoui:bug-1115494 to mozilla-b2g:master

Throwing in my review stamp to appease Autolander. Not sure why it commented twice, should fix that..

Comment 14

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/1be6a7672f63ead6eca34941df2b6407e4c0ea19

Comment 15

[Elie]

Attachment: 2015-01-15-05-46-25.png

This issue does not exist on Flame 2.2
Gaia-Rev        7c5b27cad370db377b18a742d3f3fdb0070e899f
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/ce27f2692382
Build-ID        20150115002505
Version         37.0a2
Reproduce rate 0/5