Closed Bug 1115607 Opened 7 years ago Closed 7 years ago

[v2.0m] emulator-jb build bustage in dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp

Categories

(Firefox OS Graveyard :: Bluetooth, defect)

ARM
Gonk (Firefox OS)
defect
Not set
critical

Tracking

(blocking-b2g:2.0M+, b2g-v1.4 unaffected, b2g-v2.0 unaffected, b2g-v2.0M fixed, b2g-v2.1 unaffected, b2g-v2.2 unaffected)

RESOLVED FIXED
blocking-b2g 2.0M+
Tracking Status
b2g-v1.4 --- unaffected
b2g-v2.0 --- unaffected
b2g-v2.0M --- fixed
b2g-v2.1 --- unaffected
b2g-v2.2 --- unaffected

People

(Reporter: seinlin, Assigned: shawnjohnjr)

References

Details

(Whiteboard: [2.0m_Only][blueangel])

Attachments

(1 file, 2 obsolete files)

gecko/dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp:1433:27: error: 'const struct bt_interface_t' has no member named 'config_hci_snoop_log'
make[1]: *** [BluetoothServiceBluedroid.o] Error 1
Assignee: nobody → shuang
Summary: emulator-jb build bustage in dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp → [v2.0m] emulator-jb build bustage in dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp
Comment on attachment 8541585 [details] [diff] [review]
bug1115607-2.0m.patch

config_hci_snoop_log was introduced after KK release.
Attachment #8541585 - Flags: review?(btian)
Whiteboard: [2.0m_Only][blueangel]
Comment on attachment 8541585 [details] [diff] [review]
bug1115607-2.0m.patch

Review of attachment 8541585 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with comment addressed.

::: dom/bluetooth/bluedroid/BluetoothServiceBluedroid.cpp
@@ +1424,5 @@
>  
>  void
>  BluetoothServiceBluedroid::ConfigHciDumpLog(bool aEnabled)
>  {
> +#if ANDROID_VERSION > 18

Use >= 19 for consistency under dom/bluetooth/.
Attachment #8541585 - Flags: review?(btian) → review+
Josh, 2.0m need this bug.
blocking-b2g: --- → 2.0M?
blocking-b2g: 2.0M? → 2.0M+
Blocks: Woodduck
https://tbpl.mozilla.org/?tree=Try&rev=75797e7367ab
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.