1115622 - [Bluetooth] decouple bluetoothTransfer and NfcHandoverManager's dependency

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Bluetooth, defect)

Description

[[e-mail]]

Currently bluetoothTransfer and NfcHandoverManager are reference to each other.
We could decouple it via event.

also need fix:
navigator.bluetooth should be readonly, so the current way to mockup bluetooth in NfcHandoverManager should be corrected.

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] gasolin:issue-1115622 to mozilla-b2g:master

Comment 2

[[e-mail]]

Comment on attachment 8541581 [details] [review]
[PullReq] gasolin:issue-1115622 to mozilla-b2g:master

I use event to do the first step of decoupling.

we may need another file to really decouple the 2 way dependency between bt transfer and nfc handover.

Comment 3

[[e-mail], [e-mail]]

Comment on attachment 8541581 [details] [review]
[PullReq] gasolin:issue-1115622 to mozilla-b2g:master

Fred, Beside of moving event to `handleEvent` in bluetooth_transfer.js, I'm okay for the change here. Thanks.

Comment 4

[GitHub Autolander Bot]

Attachment: [PullReq] gasolin:issue-1115622-2 to mozilla-b2g:master

Comment 5

[[e-mail]]

Comment on attachment 8544385 [details] [review]
[PullReq] gasolin:issue-1115622-2 to mozilla-b2g:master

I removed handleEvent and test fine in real device. Ready for review

Comment 6

[[e-mail], [e-mail]]

Comment on attachment 8544385 [details] [review]
[PullReq] gasolin:issue-1115622-2 to mozilla-b2g:master

Thanks for Fred's effort. r+ without nits.

Comment 7

[[e-mail]]

add extra _ for private function names.

merged to master https://github.com/mozilla-b2g/gaia/commit/cd5c88c77debee57c87da79a3995bb34521fb14b
thanks!

Comment 8

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Note: Until bug 1095028 lands, the patch *must* have a review by a suggested reviewer. If you are the patch author, you can leave an additional R+ on the attachment for autolander to process it.

Comment 9

[GitHub Autolander Bot]

Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.

Note: Until bug 1095028 lands, the patch *must* have a review by a suggested reviewer. If you are the patch author, you can leave an additional R+ on the attachment for autolander to process it.