1115668 - Inappropriate mixed content warning message

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Masatoshi Kimura [:emk]]

Steps to reproduce:
1. Open any web pages containing mixed display content (e.g. https://xkcd.com ).
2. Open Web Console.

Actual result:
Loading mixed (insecure) display content on a secure page "http://imgs.xkcd.com/static/terrible_small_logo.png"

Expected result:
Loading mixed (insecure) display content "http://imgs.xkcd.com/static/terrible_small_logo.png" on a secure page

The URL points the insecure subresource, not the secure toplevel resource.

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: patch

Comment 2

[Tanvi Vyas[:tanvi]]

Comment on attachment 8541695 [details] [diff] [review]
patch

Thanks for catching this and providing a fix Masatoshi!

Comment 3

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/470c550c782b

Comment 4

[Carsten Book [:Tomcat]]

sorry had to back this out for breaking tests like https://treeherder.mozilla.org/logviewer.html#?job_id=4993157&repo=mozilla-inbound

Comment 5

[Masatoshi Kimura [:emk]]

Sorry, relanded with the test fix:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=519d35fdd73e
https://hg.mozilla.org/integration/mozilla-inbound/rev/ecc306809984

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ecc306809984

Comment 7

[[:fabrice] Fabrice Desré]

https://hg.mozilla.org/projects/cypress/rev/db233d1e9887