Closed Bug 1115714 Opened 9 years ago Closed 9 years ago

5% Linux64 Dromaeo DOM regression on Inbound (v.37) Dec 22 from push 7f84fe59708a

Categories

(Core :: JavaScript Engine: JIT, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: jmaher, Unassigned)

References

Details

(Keywords: perf, regression, Whiteboard: [talos_regression])

you can see a dromaeo dom regression here:
http://graphs.mozilla.org/graph.html#tests=%5B%5B73,131,35%5D%5D&sel=1419222069827.7446,1419301532601.467,650,1000&displayrange=7&datatype=running

I did a bunch of retriggers on treeherder:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&filter-searchStr=linux%20x64%20talos%20dromaeo&fromchange=1ce0671489ad&tochange=3f08b1d1f293

It appears that this changeset changed the value from a range of 890-930 and dropped it down to a range of 870-900:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7f84fe59708a

Dromaeo DOM is run as the 'd' job on talos, when testing a fix for this you can push to try server and see if it fixes it by:
try: -b o -p linux64 -u none -t dromaeojs

I recommend retriggering a few times, but in general your values for dromaeo_dom should be >900.
:nbp, can you look into this regression.  I don't see improvements coming from this.  Quite possible there is a better way to fix this security bug by reducing the performance impact.
Flags: needinfo?(nicolas.b.pierron)
To be honest, I do not see how in this patch could cause such regression.  This patch add an AutoEnterAnalysis in a slow path.  This AutoEnterAnalysis is not even supposed to be slow as there is nothing to invalidate as the Recover instructions are not monitoring any results (no way associate the result to any code location).
Flags: needinfo?(nicolas.b.pierron)
ok, this is frustrating, looking at the graph with future data points:
http://graphs.mozilla.org/graph.html#tests=%5B%5B73,131,35%5D%5D&sel=none&displayrange=30&datatype=running

we can see that there was a regression for a solid day or so, then it went away.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.