Closed Bug 1115761 Opened 5 years ago Closed 5 years ago

Clean up NSS-/NSPR-related stuff in mozilla::pkix

Categories

(Core :: Security: PSM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: briansmith, Assigned: briansmith)

Details

Attachments

(4 files)

No description provided.
I'm working on adding OpenSSL-based variants of these functions so that users of mozilla::pkix can choose between NSS or {Boring|Libre|Ope}SSL, and it is better for the NSS-based and OpenSSL-based functions to have different names. I'm planning to use an "EVP" or "OpenSSL" suffix for the OpenSSL-based counterparts.
Attachment #8541778 - Flags: review?(jjones)
Brian - I'm still on PTO/travel today, but I'll be back in the office tomorrow and will go through your reviews. Sorry for the delay!
Comment on attachment 8541774 [details] [diff] [review]
Part 1: Remove obsolete references to NSS stuff in comments

Review of attachment 8541774 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me.
Attachment #8541774 - Flags: review?(jjones) → review+
Comment on attachment 8541775 [details] [diff] [review]
Part 2: Use NotReached consistently in pkixnss.cpp

Review of attachment 8541775 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me, too.
Attachment #8541775 - Flags: review?(jjones) → review+
Comment on attachment 8541778 [details] [diff] [review]
Part 3: Add "NSS" to the names of NSS-based crypto functions

Review of attachment 8541778 [details] [diff] [review]:
-----------------------------------------------------------------

Good to me, too.
Attachment #8541778 - Flags: review?(jjones) → review+
Comment on attachment 8541795 [details] [diff] [review]
Add "fall through" comment in pkixnss

Review of attachment 8541795 [details] [diff] [review]:
-----------------------------------------------------------------

All of these patches look fine to me, Brian.
Attachment #8541795 - Flags: review?(jjones) → review+
You need to log in before you can comment on or make changes to this bug.