From Bugzilla Helper: User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.6+) Gecko/20011122 BuildID: 2001112208 When having multiple tabs open, right clicking on the close tab button displays the context menu AND closes a tab. Reproducible: Always Steps to Reproduce: 1.Start mozilla 2.Press Ctrl-T 3.Right click the close tab icon in the upper right of the tab bar Actual Results: A tab is closed and the context menu is displayed Expected Results: Only the context menu should be displayed.
Created attachment 58962 [details] [diff] [review] The right patch to fix this bug. Sorry, I attached the wrong patch.
shouldn't it be using oncommand?
Created attachment 59040 [details] [diff] [review] Patch using a toolbarbutton oncommand did not work, because the closebox is an image, not a button. So I changed it to be a toolbar button. Unfortunatly I only noticed later that bug 104834 has a patch, that does exactly the same :( (stupid me). Attaching the patch anyway, because it adds the functionality to disable the button, when there is only one tab (which imho is needed to fix bug 109651).
Latest patch looks good. I'd be nice if cnecked-in sometime.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.1
This has been fixed by hewitts checkin last night (Works in linux build 2001121921). My patch is probably obsoleted by the checkin, which is unfortunate, because it also fixed bug 109651.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
verified fixed using 2002.01.29.1x comm bits on linux rh7.2, mac 10.1.2 and win2k. right-clicking on the [X] close widget now only brings up the context menu, and doesn't close the tab inadvertently.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.