Closed Bug 1115903 Opened 5 years ago Closed 5 years ago

Remove workarounds for VS2010 from mozilla::pkix

Categories

(Core :: Security: PSM, defect, minor)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: briansmith, Assigned: briansmith)

References

Details

Attachments

(2 files)

Now that MSVC2010 is no longer supported for building Gecko [1], we no longer need any workarounds that were added for that old compiler.

[1] https://groups.google.com/d/topic/mozilla.dev.platform/4p9z8XZ4enY/discussion
Attachment #8541873 - Flags: review?(mmc)
Comment on attachment 8541873 [details] [diff] [review]
Part 1: Remove VS2010 workarounds

Review of attachment 8541873 [details] [diff] [review]:
-----------------------------------------------------------------

::: security/pkix/lib/pkixder.h
@@ -166,5 @@
>  inline Result
>  Nested(Reader& input, uint8_t outerTag, uint8_t innerTag, Decoder decoder)
>  {
> -  // XXX: This doesn't work (in VS2010):
> -  // return Nested(input, outerTag, bind(Nested, _1, innerTag, decoder));

It doesn't matter any more whether "return Nested(input, outerTag, bind(Nested, _1, innerTag, decoder));" works in any compiler. Soon we'll replace the uses of bind with lambdas.
Comment on attachment 8541873 [details] [diff] [review]
Part 1: Remove VS2010 workarounds

Review of attachment 8541873 [details] [diff] [review]:
-----------------------------------------------------------------

Great! I poked around the thread in comment 1 to find https://bugzilla.mozilla.org/show_bug.cgi?id=1085767 which hopefully addresses Thunderbird issues.
Attachment #8541873 - Flags: review?(mmc) → review+
Comment on attachment 8541874 [details] [diff] [review]
Part 2: Delete most assignment operators and some copy constructors

Review of attachment 8541874 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM, but did you mean to ask jcj for review instead?
Attachment #8541874 - Flags: review?(mmc) → review+
Depends on: 1117003
You need to log in before you can comment on or make changes to this bug.