1115957 - Browser Console does not launch with -jsconsole after several restart

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[Alice0775 White]

Bug 1084509 does not fix the problem.
I can reproduce the problem on Aurora36.0a2 and Nightly37.0a1.
Firefox35b6 seems OK.

Reproducible: always

Steps To Reproduce:
1. Create new profile
2. Start firefox with -jsconsole -no-remote -P
3. Choose the created new profile in step 1 and start browser
   --- observe Browser Console

4. Exit browser from menu with Alt > f > x
5. Repeat step 2 - 5 

Actual Results:
Browser Console would not open.  And the problem is persistent.
And Alt > Tools > Web Developer > Browser Concole (Ctrl+Shift+J) is also failed.

The following error in Error Console(you need set devtools.errorconsole.enabled = true)

Timestamp: 2014/12/28 18:37:27
Error: error occurred while processing 'listTabs: TypeError: this._getChildren(...) is undefined
Stack: BrowserTabList.prototype._getBrowsers@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/webbrowser.js:281:25
BrowserTabList.prototype.getList@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/webbrowser.js:314:3
RootActor.prototype.onListTabs@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/root.js:285:12
DSC_onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js:1414:15
LocalDebuggerTransport.prototype.send/<@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/transport/transport.js:545:11
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14
Line: 281, column: 24
Source File: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js
Line: 1286


Timestamp: 2014/12/28 18:37:27
Error: onPacket threw an exception: Error: Server did not specify an actor, dropping packet: {"error":"unknownError","message":"error occurred while processing 'listTabs: TypeError: this._getChildren(...) is undefined\nStack: BrowserTabList.prototype._getBrowsers@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/webbrowser.js:281:25\nBrowserTabList.prototype.getList@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/webbrowser.js:314:3\nRootActor.prototype.onListTabs@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/actors/root.js:285:12\nDSC_onPacket@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js:1414:15\nLocalDebuggerTransport.prototype.send/<@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/transport/transport.js:545:11\nmakeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14\nmakeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14\nLine: 281, column: 24"}
Stack: DebuggerClient.prototype.onPacket@resource://gre/modules/devtools/dbg-client.jsm:888:1
LocalDebuggerTransport.prototype.send/<@resource://gre/modules/devtools/dbg-client.jsm -> resource://gre/modules/devtools/transport/transport.js:545:11
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14
makeInfallible/<@resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js:83:14
Line: 888, column: 0
Source File: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js
Line: 59


Expected Results:
Browser Console should open

Comment 1

[Alice0775 White]

Regression window:

#1: completely broken -jsconsole (not strat Browser Console)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=01f04d75519d&tochange=c76eb2abb768
Regressed by: bug 975084

#2: Partially fixed. However, It is broken after several restart.
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=580073ea1544&tochange=4c449dcda453
Regressed by: Bug 1084509


I think bug 975084 should be backed out on Aurora36.0a2 before uplift to Beta36.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: bz://1115957/jryans

Comment 3

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

/r/1765 - Bug 1115957 - Protect DevTools from empty browsers array. r=ochameau

Pull down this commit:

hg pull review -r cd2d17660ec4d5a8570305a15a140391591871e0

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8a9df0da159d

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://hg.mozilla.org/integration/fx-team/rev/d075ae34162c

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d075ae34162c

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8542253 [details]
MozReview Request: bz://1115957/jryans

Approval Request Comment
[Feature/regressing bug #]: Bug 975084
[User impact if declined]: Browser console may fail to open during early Firefox startup (command line option, etc.)
[Describe test coverage new/current, TBPL]: on m-c
[Risks and why]: Low, DevTools only
[String/UUID change made/needed]: None

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/547ac027bc25

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: MozReview Request: Bug 1115957 - Protect DevTools from empty browsers array. r=ochameau