Comment for JS_GetExternalStringFinalizer does not match to current implementation.

RESOLVED FIXED in mozilla37

Status

()

Core
JavaScript Engine
--
minor
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: arai, Assigned: arai)

Tracking

Trunk
mozilla37
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
> /*
>  * Return the 'closure' arg passed to JS_NewExternalStringWithClosure or
>  * nullptr if the external string was created via JS_NewExternalString.
>  */
> extern JS_PUBLIC_API(const JSStringFinalizer *)
> JS_GetExternalStringFinalizer(JSString *str);

It returns the `fin` parameter of JS_NewExternalString, right?
(Assignee)

Updated

3 years ago
Blocks: 724810
(Assignee)

Comment 1

3 years ago
Created attachment 8542040 [details] [diff] [review]
Fix comment for JS_GetExternalStringFinalizer.

Green on try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=47c660451d8b
Attachment #8542040 - Flags: review?(luke)

Comment 2

3 years ago
Comment on attachment 8542040 [details] [diff] [review]
Fix comment for JS_GetExternalStringFinalizer.

Review of attachment 8542040 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks!
Attachment #8542040 - Flags: review?(luke) → review+
https://hg.mozilla.org/mozilla-central/rev/ade74ec9427c
Assignee: nobody → arai_a
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.