Closed Bug 1115996 Opened 7 years ago Closed 7 years ago

Comment for JS_GetExternalStringFinalizer does not match to current implementation.

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: arai, Assigned: arai)

References

Details

Attachments

(1 file)

> /*
>  * Return the 'closure' arg passed to JS_NewExternalStringWithClosure or
>  * nullptr if the external string was created via JS_NewExternalString.
>  */
> extern JS_PUBLIC_API(const JSStringFinalizer *)
> JS_GetExternalStringFinalizer(JSString *str);

It returns the `fin` parameter of JS_NewExternalString, right?
Blocks: 724810
Comment on attachment 8542040 [details] [diff] [review]
Fix comment for JS_GetExternalStringFinalizer.

Review of attachment 8542040 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks!
Attachment #8542040 - Flags: review?(luke) → review+
https://hg.mozilla.org/mozilla-central/rev/ade74ec9427c
Assignee: nobody → arai_a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.