1116071 - Video headers in RTL have no enough space before them

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Video, defect)

Description

[Ahmed Nefzaoui [:Nefzaoui]]

Attachment: Bug Screenshot

Headers of groups of videos where there is information about videos' date have no space before them (at their right) which is the equivalent of the padding before them in LTR at the far left.

Comment 1

[GitHub Autolander Bot]

Attachment: [PullReq] anefzaoui:bug-1116071 to mozilla-b2g:master

Comment 2

[Ahmed Nefzaoui [:Nefzaoui]]

Comment on attachment 8542063 [details] [review]
[PullReq] anefzaoui:bug-1116071 to mozilla-b2g:master

Only this patch left to wrap up RTL for Video module.
Please review :)

Comment 3

[Ahmed Nefzaoui [:Nefzaoui]]

Attachment: Screenshot - Patch Applied

Hey Stephany
How does that look? :)
Thanks!

Comment 4

[David Flanagan [:djf]]

Comment on attachment 8542063 [details] [review]
[PullReq] anefzaoui:bug-1116071 to mozilla-b2g:master

Thank you Ahmed. This looks good. Setting needinfo for Russ so he is aware of this change.

What's going on at the bottom of the screenshots you attached? That "MB 12.39" text looks like some kind of bug to me.  If that is something you can reproduce please file a bug. And if it is not an l10n bug that you plan to work on, please let Russ know about it.

Comment 5

[Ahmed Nefzaoui [:Nefzaoui]]

(In reply to David Flanagan [OOO 1/5-1/12] [:djf] from comment #4)
> Comment on attachment 8542063 [details] [review]
> [PullReq] anefzaoui:bug-1116071 to mozilla-b2g:master
> 
> Thank you Ahmed. This looks good. Setting needinfo for Russ so he is aware
> of this change.
> 
> What's going on at the bottom of the screenshots you attached? That "MB
> 12.39" text looks like some kind of bug to me.  If that is something you can
> reproduce please file a bug. And if it is not an l10n bug that you plan to
> work on, please let Russ know about it.

Thanks!
That's just the developer tools from HUD activated while taking the screenshot, they're as everything else lacking a little RTL love :)

Comment 6

[Stephany Wilkes]

Comment on attachment 8542068 [details]
Screenshot - Patch Applied

Looks good, Ahmed - thank you. Sorry for the delay; I was out for the Christmas and New Year holiday.

Comment 7

[Russ Nicoletti [:russn]]

David, thanks for the NI. I will incorporate this change into the css changes I'm making for moving the video controls into a web component.

Comment 8

[Ahmed Nefzaoui [:Nefzaoui]]

Thanks!

Comment 9

[GitHub Autolander Bot]

Pull request has landed in master: https://github.com/mozilla-b2g/gaia/commit/55be22b4a8233f61fe4bc3839e2c1600470b10ad

Comment 10

[Lancy(Leave from Mozilla)]

Test case has been added in moztrap:
https://moztrap.mozilla.org/manage/case/15194/

Comment 11

[Sue]

Attachment: video_header.png

This issue has been verified successfully on Flame 2.2/3.0, headers of groups of videos where there is information about videos' date have a appropriate space before them (at their right) which is the equivalent of the padding before them in LTR at the far left.
See attachment:video_header.png
Rate:0/5

Flame 2.2 build: pass
Build ID               20150315162500
Gaia Revision          a6b2d3f8478ec250beb49950fecbb8a16465ff6f
Gaia Date              2015-03-15 14:33:22
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/18619f8f6c5c
Gecko Version          37.0
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150315.195030
Firmware Date          Sun Mar 15 19:50:42 EDT 2015
Bootloader             L1TC000118D0

Flame 3.0 build: pass
Build ID               20150315160203
Gaia Revision          d4177902b04b8fedcb7df9a30ae6e9677e03d2d4
Gaia Date              2015-03-13 15:58:35
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/af68c9c0e903
Gecko Version          39.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150315.192711
Firmware Date          Sun Mar 15 19:27:22 EDT 2015
Bootloader             L1TC000118D0