111614 - parseFromString makes modal windows non-modal.

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[Garth Smedley]

Calling DOMParser parseFromString from a modal window's onload function makes
the window non-modal.

Comment 1

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Ugh! One more problem because we cheat: we use the modal window event loop to
make things synchronous. This will fix itself when bug 65985 is fixed.

Comment 2

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Actually I now know how to do this, I already have a patch for XMLHttpRequest
syncload for 1.3beta. I should have time for this in 1.4alpha.

Comment 3

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Well, I lied, I made the patch already... attaching.

It would be nice to get a testcase for this, though. Garth?

Comment 4

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Attachment: Proposed fix

Comment 5

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Comment on attachment 111745 [details] [diff] [review]
Proposed fix

Here is basically the same thing as XMLHttpRequest sync load, now for DOMParser
(which I had forgotten).

Comment 6

[Darin Fisher]

Comment on attachment 111745 [details] [diff] [review]
Proposed fix

sr=darin

Comment 7

[Jesse Ruppell]

Heikki:  Garth won't be able to produce a testcase since he isn't working with
us any longer.  If it is necessary, I can probably put something together within
a week (after I get through my current development crunch) - but let me know.

Thanks muchly for addressing this.

Comment 8

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 111745 [details] [diff] [review]
Proposed fix

r=me. Bit it'd be really nice if we could find a simpler solution to this whole
blocking thing. Spinning a new eventqueue seems exsessive for parsing a string.

Comment 9

[Heikki Toivonen (remove -bugzilla when emailing directly)]

Fixed.

Jesse, I was unable to reproduce the bug even with your instructions, so please
verify this fix as soon as you can. This fix should fix your problem, as well as
another problem: in embedding parseFromString returns too early if the string to
parse makes the parser block (there was an xml-stylesheet PI for example). Thanks.