Closed Bug 1116170 Opened 11 years ago Closed 11 years ago

missing symbols report is missing some data

Categories

(Socorro :: Backend, task)

Product:
Socorro
Component:
Backend
Type:
task
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ted, Assigned: rhelmer)

Details

Somewhere in our missing symbols reporting pipeline we're losing data. Here's a crash report from 2014-12-20: https://crash-stats.mozilla.com/report/index/da6d7233-0cc9-4cb1-87c4-2fb312141220 It has missing symbols for ntdll.dll. That module isn't in the missing-symbols.txt file for that day (I also checked the 19th and 21st, no dice). That's an important Windows 8.1 library that we're missing symbols for, so I would expect it to show up in the reports.
I don't see any errors running the processor rule for this crash ID, and I don't see this file in the missing_symbols table at all so it's probably something wrong with the rule. I'll take a look and we can reprocess if necessary.
I don't think reprocessing is necessary, if you can fix the missing data issue we can just use the latest reports.
Assignee: nobody → rhelmer
Status: NEW → ASSIGNED
I can repro this locally, looks like just a typo in the rule. Not sure how this ever works now :) Also, added a GROUP BY in the report query so we don't get duplicates there. We'll need to reprocess.
(In reply to Ted Mielczarek [:ted.mielczarek] from comment #2) > I don't think reprocessing is necessary, if you can fix the missing data > issue we can just use the latest reports. Missed this before my last comment - OK WFM
Turns out I can't repro this locally - withdrew PR while investigating further.
Found the actual problem, was returning from the function early incorrectly. PR: https://github.com/mozilla/socorro/pull/2532
Commits pushed to master at https://github.com/mozilla/socorro https://github.com/mozilla/socorro/commit/17cc2b349754e4e241404bc29d3cf0c82955576f bug 1116170 - group reports to elminate duplicates https://github.com/mozilla/socorro/commit/117bffea5024cb694fd1888e13f47402968bb619 fix bug 1116170 - do not return early if missing_symbols not in particular module https://github.com/mozilla/socorro/commit/a8adba2ac34976bd1f34f073d818f3a8e3013b1b Merge pull request #2532 from rhelmer/bug1116170-missing_symbols-missing-symbols Bug1116170 missing symbols missing symbols
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.