1116199 - Console eval broken with servers before 37 (missing evaluateJSAsync)

Status: RESOLVED FIXED

(DevTools :: Console, defect)

Description

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

In bug 1088861, the console changed to use a new "evaluateJSAsync" actor method.

However servers before 37 don't have this method, so console eval is now broken for them.

Traits or similar feature detection should be used client-side to detect if this server method is available before use.

Comment 1

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Brian, would you be able to look at this since you worked on bug 1088861?

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

[Tracking Requested - why for this release]: DevTools console broken when connecting to any previous version, e.g. all B2G simulators, old Fennec, etc.

Comment 3

[Brian Grinstead [:bgrins]]

(In reply to J. Ryan Stinnett [:jryans] from comment #1)
> Brian, would you be able to look at this since you worked on bug 1088861?

Yes, I'll fix this

Comment 4

[Brian Grinstead [:bgrins]]

Attachment: evaluateJSAsync-backwards-compat.patch

What do you think?  I tested with a simulator and all seemed well.

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8544116 [details] [diff] [review]
evaluateJSAsync-backwards-compat.patch

Review of attachment 8544116 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thanks!

::: toolkit/devtools/webconsole/client.js
@@ +136,5 @@
>     * See evaluateJS for parameter and response information.
>     */
>    evaluateJSAsync: function(aString, aOnResponse, aOptions = {})
>    {
> +    // Pre-37 clients need to do sync evaluation.

Nit: Pre-37 servers don't support async evaluation

Comment 6

[Brian Grinstead [:bgrins]]

Attachment: evaluateJSAsync-backwards-compat.patch

Updated comment

Comment 7

[Brian Grinstead [:bgrins]]

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=881ed49714fb

Comment 8

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/integration/fx-team/rev/0dd788e4b214

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/0dd788e4b214