Closed
Bug 1116222
Opened 9 years ago
Closed 9 years ago
talos run_tests.py should validate that the pageloader manifest file exists before running the test
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jmaher, Unassigned, Mentored)
References
Details
(Whiteboard: [good first bug][lang=python])
Attachments
(1 file)
1.13 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
When talos runs a pageloader test, it reads a manifest of urls to load. this is passed to the pageloader extension as a file. This file lives on the filesystem, but before we launch the browser we never verify that the file exists. When developing tests or running stuff locally, it is easy to run into a scenario where the manifest file doesn't exist and you get frustrated figuring out the problem. I would like to take the value for tpmanifest and verify it exists on the filesystem: http://hg.mozilla.org/build/talos/file/tip/talos/run_tests.py#l45 To test this out- works: ./talos -e `which firefox` -a tsvgx --develop should fail: ./talos -e `which firefox` -a tp5o --develop
Reporter | ||
Comment 1•9 years ago
|
||
to learn more about Talos and how to get started here is a wiki outlining the work: https://wiki.mozilla.org/Auto-tools/Projects/Talos
Comment 2•9 years ago
|
||
I would like to work on this
Reporter | ||
Comment 3•9 years ago
|
||
Wonderful, Ujjwal, please get setup and start working on the patch. Once you have a patch I will gladly assign this to you. Keep in mind that no question is too simple, you can ask here in the bug or in irc (irc.mozilla.org, ateam channel, I am jmaher).
Hi Joel How should I figure out the directory structure for this? Let's say if I run the command ./talos -e `which firefox` -a tsvgx --develop and when I check for test['tpmanifest'] it returns file:/Users/xyz/Documents/Mozilla/talos/talos/page_load_test/svgx/svgx.manifest.develop How does it map the tsvgx to svgx directory? For the command ./talos -e `which firefox` -a tp5o --develop it throws: IOError: [Errno 2] No such file or directory: '/Users/xyz/Documents/Mozilla/talos/talos/page_load_test/tp5n/tp5o.manifest' How is the test mapping to the directory?
Reporter | ||
Comment 5•9 years ago
|
||
Hi Vidya, it looks like Ujjwal took this bug up. We chatted in IRC today and realized that this is just needing to remove a comment as there is other code which throws an error that makes logical sense when we have a missing manifest. I have yet to see a patch to remove the todo line from the source which is mentioned here: http://hg.mozilla.org/build/talos/file/tip/talos/run_tests.py#l45 Just to make sure we don't look into the issue again, it is important to remove any comments which could cause confusion.
Comment 6•9 years ago
|
||
Attachment #8543492 -
Flags: review?(jmaher)
Reporter | ||
Comment 7•9 years ago
|
||
Comment on attachment 8543492 [details] [diff] [review] bug1116222_remove_todo.diff Review of attachment 8543492 [details] [diff] [review]: ----------------------------------------------------------------- thanks!
Attachment #8543492 -
Flags: review?(jmaher) → review+
Reporter | ||
Comment 8•9 years ago
|
||
https://hg.mozilla.org/build/talos/rev/4693475155fa
Reporter | ||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•