If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

DoStringConcat does not handle exceptions

RESOLVED DUPLICATE of bug 1117085

Status

()

Core
JavaScript Engine
RESOLVED DUPLICATE of bug 1117085
3 years ago
11 months ago

People

(Reporter: terrence, Assigned: terrence)

Tracking

({sec-moderate})

Trunk
sec-moderate
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

3 years ago
Created attachment 8542335 [details] [diff] [review]
doconcatstrings_exception-v0.diff

It could return false because we need to GC, or it could return false because we're throwing. I guess we need to handle the throwing case explicitly wherever we use the NoGC/Root/CanGC trick.
Attachment #8542335 - Flags: review?(jorendorff)
I posted a patch in bug 1117085 to pass HandleStrings, so we don't need any rooting and the NoGC/CanGC trick.

The very similar code in AddOperation still needs this fix though.
(Assignee)

Comment 2

3 years ago
Comment on attachment 8542335 [details] [diff] [review]
doconcatstrings_exception-v0.diff

Jan has a much better solution in bug 1117085.
Attachment #8542335 - Flags: review?(jorendorff)
(Assignee)

Updated

3 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → DUPLICATE
Duplicate of bug: 1117085

Updated

2 years ago
Group: core-security → core-security-release

Updated

11 months ago
Group: core-security-release
You need to log in before you can comment on or make changes to this bug.