1116337 - [dependencies] Clear Django 1.5 lint output

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Code Cleanup, defect)

Description

[James Bennett [:ubernostrum]]

Attachment: django-1.5-lint.txt

We have output from the Django compatibility linter (atatched) which needs to be reviewed and addressed.

Comment 1

[Alice Scarpa [:adusca]]

I would like to help with this bug. I was looking into it and some warnings look like false positives. The lint only checks if "if" and "cleaned_data" are in the same line https://github.com/ubernostrum/django-compat-lint/blob/master/rules/django_15.py#L24-25, 
but I think the unwanted behavior is just "if self.cleaned_data:" so there is no real problem in https://github.com/mozilla/kuma/blob/master/kuma/demos/forms.py#L171 . What should I do about those?

Comment 2

[James Bennett [:ubernostrum]]

There are almost certainly things it catches that aren't real errors, but are at least looking at. It's OK if those are the only ones left.

Comment 3

[Alice Scarpa [:adusca]]

I updated all slugify imports https://github.com/adusca/kuma/compare/bug-1116337?expand=1 . I also checked every cleaned_data warning and they were all false alarms. I cannot tell if the password hasher in https://github.com/mozilla/kuma/blob/master/kuma/users/backends.py accepts unicode or not, so I didn't do anything about that warning. Since this breaks the current code I didn't submit a pull request, should I?

Comment 4

[James Bennett [:ubernostrum]]

For now I think it's best not to pull request, since we're never going to use Django 1.5 anyway (it's past end-of-life and is no longer officially supported). We are, however, going to move to Django 1.6, so having that work available as a basis for doing an upgrade to 1.6 is useful.

What will likely happen is that over the next week or two I'll do the 1.6 cleanup alongside the larger dependency audits/updates; if you don't mind keeping your branch around for me to grab your work from, that'd be quite helpful :)

Comment 5

[MDN Team (:mdn-dev)]

Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/b9425995c5934366439e2b786bbb5e66a261a344
Bug 1116337: Clear Django 1.5 lint output.

WARNING: This commit breaks compatibility with Django 1.4.

Many of the warnings from the linter are actually spurious/overzealous
reminders about checking the existence of cleaned_data (bad), where we
actually were checking for the presence of specific elements in
cleaned_data (good), but which django-compat-lint can't handle. As
such they were left as-is, and only the actually-relevant changes
(which are fewer in number) have been made.