Closed Bug 1116340 Opened 11 years ago Closed 11 years ago

[dependencies] Clear Django 1.6 lint output

Categories

(developer.mozilla.org Graveyard :: Code Cleanup, defect)

x86
macOS
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: jbennett, Unassigned)

References

Details

Attachments

(1 file)

Attached file django-1.6-lint.txt —
We have output from the Django compatibility linter (attached) which needs to be reviewed and addressed.
Depends on: 1116337
Blocks: 1116341
Commit pushed to master at https://github.com/mozilla/kuma https://github.com/mozilla/kuma/commit/7d1cca5680a152683bcf3990fd8f52aeb5b85a8b Bug 1116340: Clear Django 1.6 lint output. This clears all the non-spurious warnings/errors from the lint output; the primary change here is transaction handling, with the changes falling into three main areas: 1. Replacing old transaction decorators with the new 'atomic' one, since it provides the behavior we wanted. 2. Removing use of 'transaction.autocommit', since autocommit is now the default behavior of Django. 3. Rewriting the page-move task -- which is probably the trickiest transaction-related code -- to temporarily disable autocommit, manually manage the page-move transaction, and turn autocommit back on afterward.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Product: developer.mozilla.org → developer.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: