[dependencies] Clear Django 1.6 lint output

RESOLVED FIXED

Status

Mozilla Developer Network
Code Cleanup
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: ubernostrum, Unassigned)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

3 years ago
Created attachment 8542353 [details]
django-1.6-lint.txt

We have output from the Django compatibility linter (attached) which needs to be reviewed and addressed.
(Reporter)

Updated

3 years ago
Depends on: 1116337
(Reporter)

Updated

3 years ago
Blocks: 1116341

Comment 1

3 years ago
Commit pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/7d1cca5680a152683bcf3990fd8f52aeb5b85a8b
Bug 1116340: Clear Django 1.6 lint output.

This clears all the non-spurious warnings/errors from the lint output;
the primary change here is transaction handling, with the changes
falling into three main areas:

1. Replacing old transaction decorators with the new 'atomic' one,
   since it provides the behavior we wanted.

2. Removing use of 'transaction.autocommit', since autocommit is now
   the default behavior of Django.

3. Rewriting the page-move task -- which is probably the trickiest
   transaction-related code -- to temporarily disable autocommit,
   manually manage the page-move transaction, and turn autocommit back
   on afterward.
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.