1116367 - MSVC2012 bustage - BaseAssembler-x86-shared.h(33) : fatal error C1083: Cannot open include file: 'inttypes.h': No such file or directory

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

10:24.37 c:/Users/Ryan/repos/mozilla-central/config/rules.mk:930: recipe for target 'RegExp.obj' failed
10:24.37 mozmake.EXE[5]: *** [RegExp.obj] Error 1
10:24.37 mozmake.EXE[5]: *** Waiting for unfinished jobs....
10:24.65 CTypes.cpp
10:24.65 c:\users\ryan\repos\mozilla-central\js\src\jit/shared/BaseAssembler-x86-shared.h(33) : fatal error C1083: Cannot open include file: 'inttypes.h': No such file or directory

Comment 1

[Dan Gohman [:sunfish]]

It appears we have "mozilla/MSIntTypes.h" which should be used here in place of <inttypes.h>. I'll submit a patch soon.

Comment 2

[Jeff Walden [:Waldo]]

No.  Use the cross-platform "mozilla/IntegerPrintfMacros.h" instead.  The other is purely an implementation detail, not meant to be used directly.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Since MSVC2013 apparently does ship inttypes.h (given the lack of bustage in automation), should we consider changing this condition to _MSC_VER < 1800?
http://mxr.mozilla.org/mozilla-central/source/mfbt/IntegerPrintfMacros.h#35

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Nevermind, I see that's what MSIntTypes.h already does, though maybe it'd be more clear still having that logic in IntegerPrintfMacros.h instead.

Comment 5

[Dan Gohman [:sunfish]]

Attachment: use-integerprintfmacros.patch

Ah, thanks for the correction. Attached is a patch which uses IntegerPrintfMacros.h. I've verified that this passes check_spidermonkey_style.py.

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Comment on attachment 8542396 [details] [diff] [review]
use-integerprintfmacros.patch

Verified locally that this un-breaks my build :)

Comment 7

[Dan Gohman [:sunfish]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6f3a35d16540

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/6f3a35d16540