1116378 - [Gallery] Back button in Crop mode is broken

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Théo Chevalier]

Attachment: Broken button, Flame 2.2

STR: 

Open Gallery
Edit a picture
Crop the picture
Press the arrow icon to go back to main edit mode view (in red on the attached screenshot)

Actual:

Pressing the button does nothing

Expected:

Pressing the button close crop mode.


I assume it has worked some day, so adding regression here :)

Tested on:
Gaia-Rev        bdedbaf9f18a43c091ede770407d68d38582fe29
Gecko-Rev       https://hg.mozilla.org/mozilla-central/rev/8850aa0f5332
Build-ID        20141229010215
Version         37.0a1
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  39
FW-Date         Thu Oct 16 18:19:14 CST 2014
Bootloader      L1TC00011880

Comment 1

[Kevin Grandon :kgrandon]

Judging from the code it looks like this is an undo button, and not a back button. I think you're supposed to press the "X" at the top left to exit. I'm going to close this as I think it's working, but also adding a needinfo on UX for awareness. Maybe we need to update the asset here to be less confusing.

Comment 2

[Théo Chevalier]

Feeling dumb right now, thanks for looking into it Kevin ;)

Maybe graying the icon until we can actually action it?

Comment 3

[Kevin Grandon :kgrandon]

Yeah, I think we need to do something. I wasn't really sure what the icon did, even after cropping the image a bit. I had to take a very close look at the screen to realize that it was reverting my cropping changes. The asset/UX probably needs updating, let's see what UX says.

Comment 4

[Stephany Wilkes]

Flagging Tif to see if she has thoughts on what to do here, and then if needed we can get a new asset.

Comment 5

[Tiffanie Shakespeare [:tif]]

The 2.2 Gallery Refresh spec covered making changes to the edit mode which included dealing with this button. 

Punam - did you have a patch that had the undo button removed? I thought I had seen something somewhere that had these UI changes done.

Comment 6

[Punam Dahiya [:pdahiya]]

(In reply to Tiffanie Shakespeare from comment #5)
> The 2.2 Gallery Refresh spec covered making changes to the edit mode which
> included dealing with this button. 
> 
> Punam - did you have a patch that had the undo button removed? I thought I
> had seen something somewhere that had these UI changes done.

It's addressed as part of Bug1087494. Thanks!

Comment 7

[Tiffanie Shakespeare [:tif]]

Awesome! Please see the bug Punam references for the patch that implements the new UI. Once that lands
this issue will go away.