1116390 - Implement %TypedArray%.prototype.{every, some}

Status: RESOLVED FIXED

(Core :: JavaScript: Standard Library, defect)

Comment 1

[ziyunfei]

Attachment: bug-1116390-v1.patch

Comment 2

[Tom S. (please needinfo tschuster)]

Comment on attachment 8542762 [details] [diff] [review]
bug-1116390-v1.patch

Review of attachment 8542762 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/ecma_6/TypedArray/every-and-some.js
@@ +90,5 @@
> +    assertThrowsInstanceOf(() => {
> +        arr.every();
> +    }, TypeError);
> +    var invalidCallbacks = [undefined, null, 1, false, "", Symbol(), [], {}, /./];
> +    invalidCallbacks.every(callback => {

forEach :)

@@ +105,5 @@
> +    // Called from other globals.
> +    if (typeof newGlobal === "function") {
> +        var every = newGlobal()[constructor.name].prototype.every;
> +        var sum = 0;
> +        every.call(new constructor([1, 2, 3]), v => sum += v);

assertEq(..., true)

@@ +139,5 @@
> +    assertEq(new constructor([1, 2, 3]).some(v => v % 2), true);
> +    assertEq(new constructor([0, 2, 4]).some(v => v % 2), false);
> +    assertEq(new constructor([1, 3, 5]).some(v => v > 2), true);
> +    assertEq(new constructor([1, 3, 5]).some(v => v < 0), false);
> +    assertEq(new constructor(10).some(v => v !== 0), false);

Wouldn't this be true?

@@ +213,5 @@
> +    assertThrowsInstanceOf(() => {
> +        arr.some();
> +    }, TypeError);
> +    var invalidCallbacks = [undefined, null, 1, false, "", Symbol(), [], {}, /./];
> +    invalidCallbacks.some(callback => {

forEach

@@ +228,5 @@
> +    // Called from other globals.
> +    if (typeof newGlobal === "function") {
> +        var some = newGlobal()[constructor.name].prototype.some;
> +        var sum = 0;
> +        some.call(new constructor([1, 2, 3]), v => {

assertEq(..., false)

Comment 3

[ziyunfei]

Comment on attachment 8542762 [details] [diff] [review]
bug-1116390-v1.patch

Review of attachment 8542762 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/ecma_6/TypedArray/every-and-some.js
@@ +139,5 @@
> +    assertEq(new constructor([1, 2, 3]).some(v => v % 2), true);
> +    assertEq(new constructor([0, 2, 4]).some(v => v % 2), false);
> +    assertEq(new constructor([1, 3, 5]).some(v => v > 2), true);
> +    assertEq(new constructor([1, 3, 5]).some(v => v < 0), false);
> +    assertEq(new constructor(10).some(v => v !== 0), false);

I guess you mean line 144? Because the `some` method always returns `false` when called on empty arrays.

Comment 4

[Tom S. (please needinfo tschuster)]

Comment on attachment 8542762 [details] [diff] [review]
bug-1116390-v1.patch

Review of attachment 8542762 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/tests/ecma_6/TypedArray/every-and-some.js
@@ +139,5 @@
> +    assertEq(new constructor([1, 2, 3]).some(v => v % 2), true);
> +    assertEq(new constructor([0, 2, 4]).some(v => v % 2), false);
> +    assertEq(new constructor([1, 3, 5]).some(v => v > 2), true);
> +    assertEq(new constructor([1, 3, 5]).some(v => v < 0), false);
> +    assertEq(new constructor(10).some(v => v !== 0), false);

Oh, sorry. I read this as new constructor([10])

Comment 5

[ziyunfei]

Attachment: review comment addressed

Comment 6

[ziyunfei]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=45887deb8cfd

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c963d611da18

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c963d611da18

Comment 9

[Florian Scholz (Open Web Docs)]

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/every
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/TypedArray/some
https://developer.mozilla.org/en-US/Firefox/Releases/37#JavaScript