Example in comment for PromiseUtils.resolveOrTimeout has TypeError.

RESOLVED FIXED in mozilla37

Status

()

defect
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: arai, Assigned: arai)

Tracking

unspecified
mozilla37
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

http://dxr.mozilla.org/mozilla-central/source/toolkit/modules/PromiseUtils.jsm#15
>   * Example:
>   * resolveOrTimeout(myModule.shutdown(), 1000, new Error("The module took too long to shutdown"));

Third argument should be a function, like:
  resolveOrTimeout(myModule.shutdown(), 1000, () => new Error("The module took too long to shutdown"));
Blocks: 1080466
Comment on attachment 8543017 [details] [diff] [review]
Fix example comment for PromiseUtils.resolveOrTimeout.

Review of attachment 8543017 [details] [diff] [review]:
-----------------------------------------------------------------

Good catch, thank you very much for the patch.
Two things before we can land it:
- can you add `,r=yoric` at the end of your commit message? we do this to track reviewers for patches;
- while you are at it, can you cut the comment line you just fixed in two, i.e. put `() => ...` on a second line?
Attachment #8543017 - Flags: review?(dteller) → review+
https://hg.mozilla.org/mozilla-central/rev/fbb35d6d4151
Assignee: nobody → arai_a
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.