Closed Bug 1116455 Opened 6 years ago Closed 6 years ago

Refactor some GC internals

Categories

(Core :: JavaScript: GC, defect)

Product:
Core
Component:
JavaScript: GC
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla37

People

(Reporter: jonco, Assigned: jonco)

Details

Attachments

(2 files)

move-isCloseToAllocTrigger
4.71 KB, patch
terrence
: review+
Details | Diff | Splinter Review
use-isIncrementalGCInProgress
20.37 KB, patch
terrence
: review+
Details | Diff | Splinter Review 
As suggested in bug 1032750, move isCloseToAllocTrigger() to the ZoneHeapThreshold class.
Attachment #8542525 - Flags: review?(terrence)
Replace comparisons of GCRuntime::incrementalState with NO_INCREMENTAL with calls to isIncrementalGCInProgress().  I changed the definition of that method to ignore the state of the pre-barrier verifier and moved that check into JS::IsIncrementalGCInProgress() which was its only caller.

If you can think of a more snappy name though I'll update it because isIncrementalGCInProgress is a bit of a mouthful.
Attachment #8542526 - Flags: review?(terrence)
Attachment #8542525 - Flags: review?(terrence) → review+
Comment on attachment 8542526 [details] [diff] [review]
use-isIncrementalGCInProgress

Review of attachment 8542526 [details] [diff] [review]:
-----------------------------------------------------------------

\o/
Attachment #8542526 - Flags: review?(terrence) → review+
You need to log in before you can comment on or make changes to this bug.