1116490 - Can't add a contact

Status: RESOLVED WONTFIX

(Hello (Loop) :: Client, defect)

Description

[Brad Lassey [:blassey] (use needinfo?)]

I tried to add snorp as a contact, after filling out the form and clicking "Add Contact" nothing happens.

Comment 1

[Maire Reavy [:mreavy]]

This is a new one that I haven't heard about and can't repro myself. I assume this is using the latest Nightly?  Do you see any error messages in the browser console?

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

This is current Nightly. Here's my console output:


no element found ClientQos:1:1
no element found ClientQos:1:1
TypeError: contact1.name is undefined: ContactsList<.sortContacts@chrome://browser/content/loop/js/contacts.js:457:11
[38]</k._bindAutoBindMethod/n@chrome://browser/content/loop/shared/libs/react-0.11.2.js:19:18363
ContactsList<.render@chrome://browser/content/loop/js/contacts.js:520:15
[38]</k._renderValidatedComponent<@chrome://browser/content/loop/shared/libs/react-0.11.2.js:19:17851
[38]</k.updateComponent<@chrome://browser/content/loop/shared/libs/react-0.11.2.js:19:17159
[38]</k._performComponentUpdate@chrome://browser/content/loop/shared/libs/react-0.11.2.js:19:16746
[38]</k.performUpdateIfNecessary@chrome://browser/content/loop/shared/libs/react-0.11.2.js:19:16329
a@chrome://browser/content/loop/shared/libs/react-0.11.2.js:21:5841
[101]</r.perform@chrome://browser/content/loop/shared/libs/react-0.11.2.js:21:22639
[101]</r.perform@chrome://browser/content/loop/shared/libs/react-0.11.2.js:21:22639
[84]</<.perform@chrome://browser/content/loop/shared/libs/react-0.11.2.js:21:6916
[84]</C<@chrome://browser/content/loop/shared/libs/react-0.11.2.js:21:7130
[101]</r.closeAll@chrome://browser/content/loop/shared/libs/react-0.11.2.js:21:23260
[101]</r.perform@chrome://browser/content/loop/shared/libs/react-0.11.2.js:21:22719
[52]</p.batchedUpdates@chrome://browser/content/loop/shared/libs/react-0.11.2.js:20:4512
s@chrome://browser/content/loop/shared/libs/react-0.11.2.js:21:6130
[38]</k.forceUpdate@chrome://browser/content/loop/shared/libs/react-0.11.2.js:19:17623
ContactsList<.handleContactAddOrUpdate@chrome://browser/content/loop/js/contacts.js:366:9
[38]</k._bindAutoBindMethod/n@chrome://browser/content/loop/shared/libs/react-0.11.2.js:19:18363
ContactsList<.componentDidMount/</<@chrome://browser/content/loop/js/contacts.js:331:11
 event-emitter.js:142:0

Comment 3

[Maire Reavy [:mreavy]]

Brad -- have you ever used this profile with anything other than the Nightly channel (i.e. Aurora or Beta)?

Mike, Mark -- Any idea what would cause this error?  (See Comment 2 from blassey for his console output.  I can't repro with my Nightly, and this is the first report of this error that I've seen.)

Comment 4

[Mark Banner (:standard8)]

This sounds a bit like bug 1092090 - but I don't see anything in the log that directly relates to it. 

Brad, could you take a look at bug 1092090 comment 0 and see if you're getting any of the messages there?

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Mark Banner (:standard8) from comment #4)
> This sounds a bit like bug 1092090 - but I don't see anything in the log
> that directly relates to it. 
> 
> Brad, could you take a look at bug 1092090 comment 0 and see if you're
> getting any of the messages there?

Is the key here using older versions of Firefox with the same profiler? If so, I haven't been doing that. I use a separate profile for my dev builds.

Comment 6

[Mike de Boer [:mikedeboer]]

Brad, could you evaluate the following in the Scratchpad - Browser mode:

```js
Cu.import("resource:///modules/loop/LoopContacts.jsm");
LoopContacts.getAll(function(err, contacts) {
  console.log(err, JSON.stringify(contacts, null, 2));
});
```

Comment 7

[Mike de Boer [:mikedeboer]]

...and tell me what that logged in the console? You can send that via email to me, if there's private data in there. Thanks!!

Comment 8

[Brad Lassey [:blassey] (use needinfo?)]

I adjusted your script to do an alert, because as we discussed in #loop it didn't work otherwise. The alert showed "[]"

Comment 9

[Mark Banner (:standard8)]

We are currently reworking the Loop "user journey" (bug 1209713) and as part of this direct calls and contacts are being removed. Therefore closing contact related bugs as wontfix.

Tracking id: contactuserjourneyclosing