1116517 - Document optional fingerprint checking in recovery packages

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[:gerard-majax]

+++ This bug was initially created as a clone of Bug #1114377 +++

Good stuff, but we really need to document this. Partial FOTA updates including the signature/hash checking functionality?

[1] https://developer.mozilla.org/en-US/Firefox_OS/Building_and_installing_Firefox_OS/Firefox_OS_update_packages

Comment 1

[:gerard-majax]

Updated: https://developer.mozilla.org/en-US/Firefox_OS/Building_and_installing_Firefox_OS/Firefox_OS_update_packages#Generating_a_partial_Gecko.2FGaia_OTA_update_MAR

Can someone please have a look and see if I missed something/proofread?

Comment 2

[dattaz]

Had a example for a .userconfig file for  fingerprints
$PRODUCT_OUT maybe say it's out/target/product/[device name]/


otherwise it seems good for me

Comment 3

[Gabriele Svelto [:gsvelto]]

I've added further documentation and tweaked the existing one. Let's ask Chris Mills for a review since he's our documentation expert as well as a native English speaker.

Comment 4

[Chris Mills [:cmills]]

Nice work! I've given the new additions a brief copy edit, and I think it reads nicely. The only question I had left: 

In the note I created that read like this: 

"Note: A complete set of these variables is defined in the Android.mk file of the gonk-misc repository."

I linked to the Github repo. Have I linked to the right place to find these variable definitions? I ask because FOTA_FINGERPRINTS doesn't appear to be mentioned in Android.mk.

Comment 5

[Gabriele Svelto [:gsvelto]]

(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #4)
> I linked to the Github repo. Have I linked to the right place to find these
> variable definitions? I ask because FOTA_FINGERPRINTS doesn't appear to be
> mentioned in Android.mk.

That's correct, FOTA_FINGERPRINTS is used by the update_tools.py script in the B2G repo, we should have clarified that:

https://github.com/mozilla-b2g/B2G/blob/d75c2351fb32216c78a1f6c50835796af8756068/tools/update-tools/update_tools.py#L837

Comment 6

[Chris Mills [:cmills]]

Ok, cool. I've included this in the same note as I mentioned before.

Comment 7

[:gerard-majax]

Are we good on this ? Can we mark this as resolved ?

Comment 8

[Chris Mills [:cmills]]

Yes, I think we're good.