Closed Bug 1116559 Opened 5 years ago Closed 5 years ago

Remove the code to handle shutdown-cleanse from the cert override service code

Categories

(Core :: Security: PSM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: ehsan, Assigned: ehsan)

Details

Attachments

(1 file)

shutdown-cleanse has not been a thing for quite a while.
Assignee: nobody → ehsan
Comment on attachment 8542646 [details] [diff] [review]
Remove the code to handle shutdown-cleanse from the cert override service code

I've not been paying any attention to anything to do with XPCOM stuff for a long time. It's better to have David review this or for him to suggest a more appropriate reviewer.
Attachment #8542646 - Flags: review?(brian) → review?(dkeeler)
Comment on attachment 8542646 [details] [diff] [review]
Remove the code to handle shutdown-cleanse from the cert override service code

Review of attachment 8542646 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM - thanks for doing this.

::: security/manager/ssl/src/nsCertOverrideService.cpp
@@ +133,5 @@
>    if (!nsCRT::strcmp(aTopic, "profile-before-change")) {
>      // The profile is about to change,
>      // or is going away because the application is shutting down.
>  
>      ReentrantMonitorAutoEnter lock(monitor);

nit: We don't need to acquire this lock here any more - RemoveAllFromMemory does it.
Attachment #8542646 - Flags: review?(dkeeler) → review+
https://hg.mozilla.org/mozilla-central/rev/d0d8a0b73ac8
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.