1116559 - Remove the code to handle shutdown-cleanse from the cert override service code

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[:ehsan akhgari]

shutdown-cleanse has not been a thing for quite a while.

Comment 1

[:ehsan akhgari]

Attachment: Remove the code to handle shutdown-cleanse from the cert override service code

Comment 2

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Comment on attachment 8542646 [details] [diff] [review]
Remove the code to handle shutdown-cleanse from the cert override service code

I've not been paying any attention to anything to do with XPCOM stuff for a long time. It's better to have David review this or for him to suggest a more appropriate reviewer.

Comment 3

[Dana Keeler (she/her) (use needinfo) (:keeler for reviews)]

Comment on attachment 8542646 [details] [diff] [review]
Remove the code to handle shutdown-cleanse from the cert override service code

Review of attachment 8542646 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM - thanks for doing this.

::: security/manager/ssl/src/nsCertOverrideService.cpp
@@ +133,5 @@
>    if (!nsCRT::strcmp(aTopic, "profile-before-change")) {
>      // The profile is about to change,
>      // or is going away because the application is shutting down.
>  
>      ReentrantMonitorAutoEnter lock(monitor);

nit: We don't need to acquire this lock here any more - RemoveAllFromMemory does it.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d0d8a0b73ac8