Closed
Bug 1116614
Opened 10 years ago
Closed 10 years ago
checksetup "use lib" called too late
Categories
(Bugzilla :: Administration, task)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.4
People
(Reporter: altlist, Assigned: altlist)
Details
Attachments
(1 file, 1 obsolete file)
|
469 bytes,
patch
|
gerv
:
review+
|
Details | Diff | Splinter Review |
Unlike the other cgi/pl scripts. checksetup.pl calls "use lib" after loading a couple modules. Problem is that the modules loaded before the "use lib" command does not look at the locally installed lib directory.
In my particular case, I needed to use the latest version of List::Util (v1.41), even though my installed perl was using v1.27.
My solution was to move the "use lib" command at least before the Safe module. See attached patch.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8542734 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8542735 -
Flags: review?(gerv)
|
|
Assignee | |
Comment 2•10 years ago
|
||
For the record, this prevented me from using the Bugzilla VCS extension. I think other extensions may get burned by this and it's a small fix.
I recommend this be included in the 5.0 branch as opposed to 6.0
Version: 5.1 → 4.5.6
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8542735 [details] [diff] [review]
v2
Review of attachment 8542735 [details] [diff] [review]:
-----------------------------------------------------------------
r=gerv.
Gerv
Attachment #8542735 -
Flags: review?(gerv) → review+
|
|
||
Updated•10 years ago
|
Flags: approval?
Flags: approval5.0?
Flags: approval4.4?
|
|
||
Updated•10 years ago
|
Assignee: administration → altlist
Status: NEW → ASSIGNED
Flags: approval?
Flags: approval5.0?
Flags: approval5.0+
Flags: approval4.4?
Flags: approval4.4+
Flags: approval+
Target Milestone: --- → Bugzilla 4.4
|
|
||
Comment 4•10 years ago
|
||
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
1612292..561465c master -> master
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
9347aa9..ce8c9ca 5.0 -> 5.0
To ssh://gitolite3@git.mozilla.org/bugzilla/bugzilla.git
87fc15f..25c0962 4.4 -> 4.4
Thanks, Albert :-) Sorry it didn't make it in before the recent release.
Gerv
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•