Enable dom.mozBrowserFramesEnabled for desktop runtime

RESOLVED WONTFIX

Status

Firefox Graveyard
Webapp Runtime
P2
normal
RESOLVED WONTFIX
3 years ago
2 years ago

People

(Reporter: irakli, Unassigned)

Tracking

Details

Attachments

(1 attachment)

Enabling dom.mozBrowserFramesEnabled just for desktop runtime will allow apps that request "browser" permission to use a browser API
https://developer.mozilla.org/en-US/docs/Web/API/Using_the_Browser_API
Comment on attachment 8542748 [details] [review]
v1

Sorry for the delay responding!  This looks good, but it could use an automated test.  Can you add one?  It should be pretty simple, take a look at browser_alarm.js, which loads a webapp that tests the ability to use the Alarm API:

https://github.com/mozilla/gecko-dev/blob/master/webapprt/test/chrome/browser_alarm.js

In this case the test would load a webapp that creates an <iframe mozbrowser> child frame, loads some content into it, and checks that the child frame behaves as expected, in particular that the content sees itself as the topmost frame in the frame hierarchy.

(The content can communicate the result of such a test by calling window.alert, which will dispatch a mozbrowsershowmodalprompt event on the <iframe mozbrowser> element in the parent frame).
Attachment #8542748 - Flags: review?(myk)
Irakli: I'll be out of town for the next three days, so I'm cc:ing Marco Castelluccio, who is a peer of the Desktop Runtime module and can review an updated patch if you submit one before I return.  Please feel free to request review from him instead to get an updated patch reviewed and landed faster!
Note that runtime tests are failing on Mac because of bug 1097243, but you should be able to run them on Linux or Windows with:

./mach webapprt-test-chrome
Priority: -- → P2
Per bug 1238079, we're going to disable the desktop web runtime and remove it from the codebase, so we won't fix these bugs in it.
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
(Assignee)

Updated

2 years ago
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.