Closed Bug 1116629 Opened 5 years ago Closed 5 years ago

Cancelling an in-progress download fails to remove the temporary file on windows

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Platform:
All
Windows 7
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla37

People

(Reporter: mossop, Assigned: mossop)

References

(Regressed 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

MozReview Request: Bug 1116629: Cancelling an in-progress download fails to remove the temporary file on windows.
39 bytes, text/x-review-board-request
Unfocused
: review+
Details 
We call to cancel channel and then immediately try to delete the file we're downloading to. On windows it is locked and so can't be deleted. We have to wait until the channel closes before deleting it.
Attached file MozReview Request: bz://1116629/Mossop (obsolete) —
Attachment #8542824 - Flags: review?(bmcbride)
/r/1833 - Bug 1116629: Cancelling an in-progress download fails to remove the temporary file on windows.

Pull down this commit:

hg pull review -r 96ea862cb713bddad8d48b14c7f296cd825ec5a7
Attachment #8542824 - Flags: review?(bmcbride) → review+
https://hg.mozilla.org/mozilla-central/rev/355be9b24453
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
Attachment #8542824 - Attachment is obsolete: true
Attachment #8618999 - Flags: review+
Regressions: 1559683
You need to log in before you can comment on or make changes to this bug.