Cancelling an in-progress download fails to remove the temporary file on windows
RESOLVED
FIXED
in mozilla37
Status
()
People
(Reporter: mossop, Assigned: mossop)
Tracking
Firefox Tracking Flags
(Not tracked)
Details
Attachments
(1 attachment, 1 obsolete attachment)
We call to cancel channel and then immediately try to delete the file we're downloading to. On windows it is locked and so can't be deleted. We have to wait until the channel closes before deleting it.
|
(Assignee) | |
Comment 1•4 years ago
|
||
Created attachment 8542824 [details]
MozReview Request: bz://1116629/Mossop
Attachment #8542824 -
Flags: review?(bmcbride)
|
|
(Assignee) | |
Comment 2•4 years ago
|
||
/r/1833 - Bug 1116629: Cancelling an in-progress download fails to remove the temporary file on windows. Pull down this commit: hg pull review -r 96ea862cb713bddad8d48b14c7f296cd825ec5a7
|
||
Updated•4 years ago
|
Attachment #8542824 -
Flags: review?(bmcbride) → review+
|
|
||
Comment 3•4 years ago
|
||
https://reviewboard.mozilla.org/r/1831/#review1239 Ship It!
|
|
(Assignee) | |
Comment 4•4 years ago
|
||
Shipped: https://hg.mozilla.org/integration/fx-team/rev/355be9b24453
|
||
Comment 5•4 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/355be9b24453
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
|
|
(Assignee) | |
Comment 6•4 years ago
|
||
Comment on attachment 8542824 [details]
MozReview Request: bz://1116629/Mossop
Attachment #8542824 -
Attachment is obsolete: true
Attachment #8618999 -
Flags: review+
|
|
(Assignee) | |
Comment 7•4 years ago
|
||
Created attachment 8618999 [details] MozReview Request: Bug 1116629: Cancelling an in-progress download fails to remove the temporary file on windows.
You need to log in
before you can comment on or make changes to this bug.
Description
•