Cancelling an in-progress download fails to remove the temporary file on windows

RESOLVED FIXED in mozilla37

Status

()

Toolkit
Add-ons Manager
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: mossop, Assigned: mossop)

Tracking

Trunk
mozilla37
All
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

3 years ago
We call to cancel channel and then immediately try to delete the file we're downloading to. On windows it is locked and so can't be deleted. We have to wait until the channel closes before deleting it.
(Assignee)

Comment 1

3 years ago
Created attachment 8542824 [details]
MozReview Request: bz://1116629/Mossop
Attachment #8542824 - Flags: review?(bmcbride)
(Assignee)

Comment 2

3 years ago
/r/1833 - Bug 1116629: Cancelling an in-progress download fails to remove the temporary file on windows.

Pull down this commit:

hg pull review -r 96ea862cb713bddad8d48b14c7f296cd825ec5a7
Attachment #8542824 - Flags: review?(bmcbride) → review+
https://reviewboard.mozilla.org/r/1831/#review1239

Ship It!
(Assignee)

Comment 4

3 years ago
Shipped: https://hg.mozilla.org/integration/fx-team/rev/355be9b24453
https://hg.mozilla.org/mozilla-central/rev/355be9b24453
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
(Assignee)

Comment 6

3 years ago
Comment on attachment 8542824 [details]
MozReview Request: bz://1116629/Mossop
Attachment #8542824 - Attachment is obsolete: true
Attachment #8618999 - Flags: review+
(Assignee)

Comment 7

3 years ago
Created attachment 8618999 [details]
MozReview Request: Bug 1116629: Cancelling an in-progress download fails to remove the temporary file on windows.
You need to log in before you can comment on or make changes to this bug.