1116680 - Add [AvailableIn="CertifiedApps"] and [CheckPermissions="mobileconnection"] to ICC interfaces

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Hsin-Yi Tsai (she/her) [:hsinyi]]

To hide MozIcc.webidl, MozIccInfo.webidl and MozIccManager.webidl from non-certified apps.

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

(In reply to Hsin-Yi Tsai [:hsinyi] from comment #0)
> To hide MozIcc.webidl, MozIccInfo.webidl and MozIccManager.webidl from
> non-certified apps.

Also MozStkCommandEvent.webidl

Comment 2

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Attachment: patch

Comment 3

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Comment on attachment 8559578 [details] [diff] [review]
patch

Review of attachment 8559578 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Olli,

Should be the last piece from my side ;)
Thank you!

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8559578 [details] [diff] [review]
patch

You should change also
partial interface Navigator {
[Throws, Pref="dom.icc.enabled", CheckPermissions="mobileconnection",  UnsafeInPrerendering]
  readonly attribute MozIccManager? mozIccManager;
};

Comment 5

[Hsin-Yi Tsai (she/her) [:hsinyi]]

review comment addressed, thank you!
https://hg.mozilla.org/integration/b2g-inbound/rev/2f8084506edf

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2f8084506edf