Closed Bug 1116680 Opened 5 years ago Closed 5 years ago

Add [AvailableIn="CertifiedApps"] and [CheckPermissions="mobileconnection"] to ICC interfaces

Categories

(Firefox OS Graveyard :: RIL, defect)

x86_64
Linux
defect
Not set

Tracking

(firefox38 fixed)

RESOLVED FIXED
2.2 S5 (6feb)
Tracking Status
firefox38 --- fixed

People

(Reporter: hsinyi, Assigned: hsinyi)

References

Details

Attachments

(1 file)

To hide MozIcc.webidl, MozIccInfo.webidl and MozIccManager.webidl from non-certified apps.
Blocks: 1116654
No longer blocks: 1116665
(In reply to Hsin-Yi Tsai [:hsinyi] from comment #0)
> To hide MozIcc.webidl, MozIccInfo.webidl and MozIccManager.webidl from
> non-certified apps.

Also MozStkCommandEvent.webidl
Assignee: nobody → htsai
Attached patch patchSplinter Review
Comment on attachment 8559578 [details] [diff] [review]
patch

Review of attachment 8559578 [details] [diff] [review]:
-----------------------------------------------------------------

Hi Olli,

Should be the last piece from my side ;)
Thank you!
Attachment #8559578 - Flags: review?(bugs)
Comment on attachment 8559578 [details] [diff] [review]
patch

You should change also
partial interface Navigator {
[Throws, Pref="dom.icc.enabled", CheckPermissions="mobileconnection",  UnsafeInPrerendering]
  readonly attribute MozIccManager? mozIccManager;
};
Attachment #8559578 - Flags: review?(bugs) → review+
review comment addressed, thank you!
https://hg.mozilla.org/integration/b2g-inbound/rev/2f8084506edf
https://hg.mozilla.org/mozilla-central/rev/2f8084506edf
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 2.2 S5 (6feb)
Depends on: 1131022
You need to log in before you can comment on or make changes to this bug.