Closed
Bug 1116707
Opened 9 years ago
Closed 9 years ago
[FFOS7715 v2.1][system]delete the downloading file in settings/downloads, pull down the utility_tray, the download_notification still exists and is in the downloading state
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(blocking-b2g:2.1+, b2g-v2.1 verified, b2g-v2.1S fixed, b2g-v2.2 verified, b2g-master verified)
People
(Reporter: David.Zhao, Assigned: mancas)
Details
(Whiteboard: [systemsfe])
Attachments
(3 files)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:36.0) Gecko/20100101 Firefox/36.0 Build ID: 20141119030200 Steps to reproduce: In WiFi environment, download one file, close WiFi, the phone is in no network environment, download file will be in the downloading state, delete the file in settings/downloads, pull down the utility_tray, the download_notification still exists and is in the downloading state 1.In WiFi environment, download one file 2.close WiFi, the phone is in no network environment, download file will be in the downloading state 3.delete the file in settings/downloads 4.pull down the utility_tray, the download_notification still exists and is in the downloading state Actual results: pull down the utility_tray, the download_notification still exists and is in the downloading state Expected results: the download_notification will disappear
Hi kenvin: I know you are expected in utility tray and notification, please help me to investigate. thanks a lot. ps: if you have any problem, please need info for me, i will reply quickly.
Flags: needinfo?(kgrandon)
Comment 2•9 years ago
|
||
I'm gonna forward this over to Aus who would probably be able to better answer a download notification question than I am.
Flags: needinfo?(kgrandon) → needinfo?(aus)
(In reply to Kevin Grandon :kgrandon from comment #2) > I'm gonna forward this over to Aus who would probably be able to better > answer a download notification question than I am. Thanks Kevin!
Hi Aus: As of comment 3, please help me. thanks a lot. ps: if you have any problem, please need info for me, i will reply quickly.
Comment 5•9 years ago
|
||
I feel like this is something that I fixed in a later build. Could the reporter retest with latest 2.1? Thanks! See bug 1077595 for more info. The fix on 2.1 landed on the 20th.
Flags: needinfo?(aus) → needinfo?(David.Zhao)
(In reply to Ghislain Aus Lacroix [:aus] from comment #5) > I feel like this is something that I fixed in a later build. Could the > reporter retest with latest 2.1? > > Thanks! > > See bug 1077595 for more info. The fix on 2.1 landed on the 20th. Hi Ghislain, I reproduce it with latest 2.1 I think there is some differet with bug 1077595 bug 1077595:the file is downloading really I report the bug is that the wifi and data is off and the file is ‘downloading’,but the ‘downloading‘ is just Performance and the download is stop in fact Please fallow the steps: 1.In WiFi environment, download one file 2.close WiFi and data, the phone is in no network environment, download file will be in the downloading state 3.delete the file in settings/downloads 4.pull down the utility_tray, the download_notification still exists and is in the downloading state
Flags: needinfo?(David.Zhao) → needinfo?(aus)
Summary: [notification]delete the downloading file in settings/downloads, pull down the utility_tray, the download_notification still exists and is in the downloading state → [FFOS7715 v2.1][system]delete the downloading file in settings/downloads, pull down the utility_tray, the download_notification still exists and is in the downloading state
Updated•9 years ago
|
Whiteboard: [systemsfe]
Comment 8•9 years ago
|
||
[Blocking Requested - why for this release]: Putting on triage radar. we are not debugging it if its not a blocking issue.
blocking-b2g: --- → 2.1?
Comment 9•9 years ago
|
||
This issue does occur on the Flame 2.2(319mb)(KK)(Full Flash). After deleting the file from settings/downloads, the file will still be showing in a downloading state in the utility tray. Environmental Variables: Device: Flame 2.2 Master (319mb)(Kitkat Base)(Full Flash) BuildID: 20150106010234 Gaia: b77e0d56d197e0ee02d801a25c784130d888c9db Gecko: 2a193b7f395c Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76 Version: 37.0a1 (2.2 Master) Firmware: V188-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Updated•9 years ago
|
status-b2g-v2.2:
--- → affected
Updated•9 years ago
|
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(pbylenga)
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → b.mcb
Assignee | ||
Comment 10•9 years ago
|
||
Hey Alive, could you review this patch? Notice that maybe we need someone from the Settings app to review the iac code in the app. Thanks!
Attachment #8545772 -
Flags: review?(alive)
Comment 11•9 years ago
|
||
Comment on attachment 8545772 [details] [review] Proposed patch While this does work, I don't like it. It doesn't allow other potential users of the downloads api to observe that the download was cancelled. Instead, we should look for 'finalized' state change of the download and remove it from notifications. If this doesn't work, then it's an API level bug that should be easy to correct.
Flags: needinfo?(aus)
Attachment #8545772 -
Flags: review?(alive) → review-
Assignee | ||
Comment 12•9 years ago
|
||
Comment on attachment 8545772 [details] [review] Proposed patch Aus, I've took into account your comments. Please review this new approach using the download state |finalized| Thanks
Attachment #8545772 -
Flags: review- → review?(aus)
Comment 13•9 years ago
|
||
Comment on attachment 8545772 [details] [review] Proposed patch lgtm! :)
Attachment #8545772 -
Flags: review?(aus) → review+
Reporter | ||
Comment 14•9 years ago
|
||
(In reply to Manuel Casas Barrado [:mancas] from comment #12) > Comment on attachment 8545772 [details] [review] > Proposed patch > > Aus, I've took into account your comments. Please review this new approach > using the download state |finalized| > > Thanks Hi Casas, Will you fix it on latest 2.1 ?
Assignee | ||
Comment 15•9 years ago
|
||
I'm working in a patch for version 2.1
Assignee | ||
Comment 16•9 years ago
|
||
The patch is ready, waiting for travis and r+. Thanks!
Attachment #8547378 -
Flags: review?(aus)
Comment 17•9 years ago
|
||
Fixed on master (v2.2): https://github.com/mozilla-b2g/gaia/commit/7717e178e1930e92c72697473b624ba1ac9a6524
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 18•9 years ago
|
||
Patch looks good for 2.1 as well, so do the tests. You'll need to ask for 2.1 approval though before it can be landed. Once it's been approved, I'll be able to land it. Thanks for the fix!
Comment 19•9 years ago
|
||
Comment on attachment 8547378 [details] [review] Proposed patch for v2.1 lgtm! :)
Attachment #8547378 -
Flags: review?(aus) → review+
Assignee | ||
Comment 20•9 years ago
|
||
Comment on attachment 8547378 [details] [review] Proposed patch for v2.1 [Approval Request Comment] [Bug caused by] (feature/regressing bug #): No regression [User impact] if declined: If the user delete a file from the settings app, the notification will not be removed, so the notification progress will never be updated [Testing completed]: Yes [Risk to taking this patch] (and alternatives if risky): Low [String changes made]: No
Attachment #8547378 -
Flags: approval-gaia-v2.1?
Comment 21•9 years ago
|
||
Can QA/reporter help verify this fix on 2.2 before we do the branch uplift ? Thanks!
Comment 22•9 years ago
|
||
This issue is verified fixed on Flame 2.2. Result: After deleting the file from Settings > Downloads, the download notification no longer exists on the utility tray. Environmental Variables: Device: Flame 2.2 (319mb, full flash) Build ID: 20150113002520 Gaia: 7c5b27cad370db377b18a742d3f3fdb0070e899f Gecko: df130262b09e Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76 Version: 37.0a2 (2.2) Firmware Version: V18D-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Keywords: verifyme
Updated•9 years ago
|
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Updated•9 years ago
|
Attachment #8547378 -
Flags: approval-gaia-v2.1? → approval-gaia-v2.1+
Comment 23•9 years ago
|
||
(In reply to Ghislain Aus Lacroix [:aus] from comment #17) > Fixed on master (v2.2): > https://github.com/mozilla-b2g/gaia/commit/ > 7717e178e1930e92c72697473b624ba1ac9a6524 Are you sure this made the cutoff for v2.2? Based on the time it was merged and the lack of seeing it in the v2.2 commits on Github, I'm skeptical.
status-b2g-master:
--- → fixed
Target Milestone: --- → 2.2 S4 (23jan)
Comment 24•9 years ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #23) > (In reply to Ghislain Aus Lacroix [:aus] from comment #17) > > Fixed on master (v2.2): > > https://github.com/mozilla-b2g/gaia/commit/ > > 7717e178e1930e92c72697473b624ba1ac9a6524 > > Are you sure this made the cutoff for v2.2? Based on the time it was merged > and the lack of seeing it in the v2.2 commits on Github, I'm skeptical. Hmm, I am curious how QA verfiied this in that case. Yeojin, can you comment ?
Flags: needinfo?(ychung)
Comment 25•9 years ago
|
||
More to the point, looking at the files changed by this commit, v2.2 tip definitely doesn't have them.
Updated•9 years ago
|
Comment 26•9 years ago
|
||
(In reply to bhavana bajaj [:bajaj] from comment #24) > (In reply to Ryan VanderMeulen [:RyanVM UTC-5] from comment #23) > > (In reply to Ghislain Aus Lacroix [:aus] from comment #17) > > > Fixed on master (v2.2): > > > https://github.com/mozilla-b2g/gaia/commit/ > > > 7717e178e1930e92c72697473b624ba1ac9a6524 > > > > Are you sure this made the cutoff for v2.2? Based on the time it was merged > > and the lack of seeing it in the v2.2 commits on Github, I'm skeptical. > > Hmm, I am curious how QA verfiied this in that case. Yeojin, can you comment > ? I was unable to reproduce the bug on today's nightly Flame 2.2. However, I DID reproduce this bug on yesterday's nightly Flame 2.2: Result: The notification tray still displays the downloading after the file is deleted from Settings > Downloads. Environmental Variables: Device: Flame 2.2 BuildID: 20150112010228 Gaia: f5e481d4caf9ffa561720a6fc9cf521a28bd8439 Gecko: bb8d6034f5f2 Gonk: a814b2e2dfdda7140cb3a357617dc4fbb1435e76 Version: 37.0a1 (2.2) Firmware: V18D-1 User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0
Flags: needinfo?(ychung)
Reporter | ||
Comment 27•9 years ago
|
||
Hi, sorry,I'm late. I verify this on 2.1, looks good. I have no 2.2 code, so ...
Flags: needinfo?(David.Zhao)
Comment 28•9 years ago
|
||
v2.1: https://github.com/mozilla-b2g/gaia/commit/d60af2eac1347424c0cada1093c5bcafa24043d9 I've verified again that the patch that landed on master cherry-picks cleanly to the v2.2 branch. I'm tempted to just push it and be done with it, but will wait for an official approval first :)
Flags: needinfo?(b.mcb)
Comment 29•9 years ago
|
||
Got IRC a+ to push this to v2.2. https://github.com/mozilla-b2g/gaia/commit/affbd8244ca5d2297aeaaa12355196108e7c4800
Comment 30•9 years ago
|
||
This issue verified successfull on Flame 2.1&2.2: Flame 2.2 Build: Gaia-Rev 7c5b27cad370db377b18a742d3f3fdb0070e899f Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/ce27f2692382 Build-ID 20150115002505 Version 37.0a2 Flame 2.1 Build: 8d4846d7bec777046dc5e3d2b8005adb1370f1f7 Gecko-Rev https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/8eb9bc3a945a Build-ID 20150115001207 Version 34.0
Comment 31•9 years ago
|
||
This issue verified successfull on Flame 2.1&2.2: refer to video VIDEO0248_Compress.MP4
Comment 32•9 years ago
|
||
v2.1s : https://github.com/mozilla-b2g/gaia/commit/d60af2eac1347424c0cada1093c5bcafa24043d9
status-b2g-v2.1S:
--- → fixed
Comment 33•9 years ago
|
||
This issue is verified fixed on Flame Master. Result: After deleting the file from Settings > Downloads, the download notification no longer exists on the utility tray. Device: Flame Master (319mb, full flash) BuildID: 20150123010227 Gaia: cba2f0bf49b882e0044c3cc583de8fcf83d2ffa4 Gecko: 494632b9afed Gonk: e7c90613521145db090dd24147afd5ceb5703190 Version: 38.0a1 (3.0 Master) Firmware: V18D-1 User Agent: Mozilla/5.0 (Mobile; rv:38.0) Gecko/38.0 Firefox/38.0
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
Updated•9 years ago
|
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
You need to log in
before you can comment on or make changes to this bug.
Description
•