1116709 - [Stingray] Improve key navigation feature

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia, defect)

Description

[Luke Chang [:lchang] (inactive)]

We fail to navigate the elements which is much bigger than the current focused one under certain circumstances.

Comment 1

[Luke Chang [:lchang] (inactive)]

Attachment: Demo

Put this file into "gaia/tv_apps/tv_shared/js/", run it in the browser and you will see the problem.

Comment 2

[Luke Chang [:lchang] (inactive)]

Attachment: Pull request to master

Hi Tzu-Lin and John,

Could you take a look at my patch? Thanks.

Comment 3

[Luke Chang [:lchang] (inactive)]

The current behavior of smart-home will become a little bit strange because the size of "div#card-list-frame" is set to be fullscreen currently. Navigating to a fullscreen element should be unexpected. We may need to fix that in advance.

Comment 4

[Luke Chang [:lchang] (inactive)]

After this patch landed, we may reconsider if the patch in Bug 1114452 is still necessary or not.

Comment 5

[Luke Chang [:lchang] (inactive)]

Comment on attachment 8542864 [details] [review]
Pull request to master

Hi Rex,

Per comment 3, you're familiar with the interaction among SpatialNavigator and Smart-Home. Could you please help on this? Thanks.

Comment 6

[John Hu [:johnhu][:johu][:醬糊小弟]]

Comment on attachment 8542864 [details] [review]
Pull request to master

Looks good to me...

When we press "right" at the top-right corner, the focus will goes to the center-right element. According to the algorithm, it is correct. But is this what UX wants? IMO, if the patch of bug 1114452 also fixed it, we may need it.

Comment 7

[Luke Chang [:lchang] (inactive)]

(In reply to John Hu [:johnhu][:johu][:醬糊小弟] (PTO from 12/27 ~ 1/4) from comment #6)
> When we press "right" at the top-right corner, the focus will goes to the
> center-right element. According to the algorithm, it is correct.

Actually, this behavior isn't correct. It's caused by what I mentioned at comment 3.

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

This patch looks good to me, but after landing we need to fix two regressions that based on
behavior of original spatial navigation:
1. (The one mentioned at comment. 3) In home-app, Pressing right key at search button
   shouldn't move focus to card list.
2. In app-deck, pressing up at second/third row of apps shouldn't move focus to the top
   scrollable.

For the first one it's just a css issue; the second one we need to adjust some structure
of home-app. So I'll hold my r+ until we can confirm those issue above are solved.

Comment 9

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8542864 [details] [review]
Pull request to master

r=me but I would suggest landing together it with bug 1120381 and bug 1118569 which contain fix to the new behavior.

Comment 10

[KM Lee [:rexboy] (inactivate after Sep. 22)]

https://github.com/mozilla-b2g/gaia/commit/6b81efbe70a9c5b1c01f40131f6bb72e08925551