Closed Bug 1116718 Opened 5 years ago Closed 5 years ago

A couple of nsViewportFrame perf improvements

Categories

(Core :: Layout, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla37

People

(Reporter: mats, Assigned: mats)

Details

(Keywords: perf)

Attachments

(2 files)

No description provided.
We already called SetOverflowAreasToDesiredBounds() here:
http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsViewportFrame.cpp#237
so we can just pass nullptr to GetAbsoluteContainingBlock()->Reflow()
when we don't want it to update the areas.
Attachment #8542896 - Flags: review?(roc)
The difference is that HasAbsolutelyPositionedChildren() also checks
there is at least one child on the relevant child list.  We need to fix
bug 1116714 for this to have an effect though. :-)

https://tbpl.mozilla.org/?tree=Try&rev=01359209c378
Attachment #8542899 - Flags: review?(roc)
Attachment #8542896 - Attachment description: art 1 - Don't bother calculating overflow areas when they will be discarded anyway. → part 1 - Don't bother calculating overflow areas when they will be discarded anyway.
https://hg.mozilla.org/mozilla-central/rev/2c26d6715f10
https://hg.mozilla.org/mozilla-central/rev/dbd12f80f9fa
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.