Closed
Bug 1116718
Opened 9 years ago
Closed 9 years ago
A couple of nsViewportFrame perf improvements
Categories
(Core :: Layout, enhancement)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla37
People
(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)
Details
(Keywords: perf)
Attachments
(2 files)
|
1.97 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
|
1.38 KB,
patch
|
roc
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•9 years ago
|
||
We already called SetOverflowAreasToDesiredBounds() here: http://mxr.mozilla.org/mozilla-central/source/layout/generic/nsViewportFrame.cpp#237 so we can just pass nullptr to GetAbsoluteContainingBlock()->Reflow() when we don't want it to update the areas.
Attachment #8542896 -
Flags: review?(roc)
|
|
Assignee | |
Comment 2•9 years ago
|
||
The difference is that HasAbsolutelyPositionedChildren() also checks there is at least one child on the relevant child list. We need to fix bug 1116714 for this to have an effect though. :-) https://tbpl.mozilla.org/?tree=Try&rev=01359209c378
Attachment #8542899 -
Flags: review?(roc)
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8542896 -
Attachment description: art 1 - Don't bother calculating overflow areas when they will be discarded anyway. → part 1 - Don't bother calculating overflow areas when they will be discarded anyway.
Attachment #8542896 -
Flags: review?(roc) → review+
Attachment #8542899 -
Flags: review?(roc) → review+
|
|
Assignee | |
Comment 3•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2c26d6715f10 https://hg.mozilla.org/integration/mozilla-inbound/rev/dbd12f80f9fa
Flags: in-testsuite-
|
||
Comment 4•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2c26d6715f10 https://hg.mozilla.org/mozilla-central/rev/dbd12f80f9fa
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in
before you can comment on or make changes to this bug.
Description
•