1116725 - TypeError : isLost is a readonly attribute

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

isLost is a read-only attribute,
I should add another [ChromeOnly] function to turn the flag to true.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Attachment: Patch

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8542905 [details] [diff] [review]
Patch

Review of attachment 8542905 [details] [diff] [review]:
-----------------------------------------------------------------

Forward r? to smaug.

When I landed Bug 1085292, I remembered I could set the isLost attribute from MozNFC(i.e. outside MozNFCTag/PeerImpl object),
but I guess there's some JS engine change or WebIDL binding change recently so setting that attribute will result error now.

In this patch I set that attribute inside the JS-Impl object, and it's working now.
r? to smaug to see this is a correct way for doing this.
Or should I create another getter for this. 

Like

_isLost: null,

get isLost() {
  return this._isLost;
}

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8542905 [details] [diff] [review]
Patch

So this works since the JS->webidl->C++->JS will end up forwarding
notifyLost() call from the caller JS to the interface implementation JS.
This is perhaps even clearer than using _isLost + getter


I don't think anything has changed in webidl bindings related to this.

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

https://hg.mozilla.org/integration/b2g-inbound/rev/dc341b949c0b

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/dc341b949c0b