Merge FrameBlender into FrameAnimator

RESOLVED FIXED in mozilla37

Status

()

defect
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: seth, Assigned: seth)

Tracking

unspecified
mozilla37
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Assignee

Description

5 years ago
After bug 1116716, FrameBlender just isn't doing very much by itself anymore - it stores a couple of compositing frames, but other than that it's mostly a set of utility methods for FrameAnimator to call. In future bugs we're going to want to do refactorings that cut across both the code in FrameAnimator and the code that's currently in FrameBlender. I think it makes sense at this point to merge FrameBlender into FrameAnimator, which will provide a good foundation for those future refactorings.
Assignee

Comment 1

5 years ago
Here's the patch. It's purely refactoring. Basically, the member variables and code from FrameBlender gets moved into FrameAnimator, with the exception of the enumerations, which turn out to make more sense living in imgFrame's header file. Then all the code that references those things gets updated.
Attachment #8542923 - Flags: review?(tnikkel)
Attachment #8542923 - Flags: review?(tnikkel) → review+
Assignee

Comment 3

4 years ago
Thanks for the review!

The failures in the try job above are all from previous patches in the patch stack, and they've now been fixed. The one exception was a failure to build on Windows because the TRANSPARENT identifier is used. =\ To work around that I renamed TRANSPARENT to SOME_TRANSPARENCY, and building on Windows is now successful, as this try job shows:

https://tbpl.mozilla.org/?tree=Try&rev=aa5ade79fd8b

Pushed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/689797cc26c4
Assignee

Comment 4

4 years ago
Here's the final version of the patch that got pushed.
Assignee

Updated

4 years ago
Attachment #8542923 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/689797cc26c4
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.