Remove the nsIPresShell* param from all frame ctors

RESOLVED FIXED in mozilla37

Status

()

Core
Layout
--
minor
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mats, Assigned: mats)

Tracking

Trunk
mozilla37
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
We've already done this for almost all frames, but not for XUL frames
and a few others.
(Assignee)

Comment 1

4 years ago
Created attachment 8542954 [details] [diff] [review]
fix

Most ctors are now 1-arg ctors so I added 'explicit' to those.
There were only a couple of places where the shell was actually used.
I replaced it with PresContext()->PresShell() which should work fine
in the body of a frame ctor.  Other than that, no significant changes.

https://tbpl.mozilla.org/?tree=Try&rev=01359209c378
Attachment #8542954 - Flags: review?(roc)
(Assignee)

Comment 3

4 years ago
I missed an 'explicit' in one place which caused static analysis to fail,
so I landed this follow-up to fix that:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3405b354e2f1
https://hg.mozilla.org/mozilla-central/rev/426055dc106a
https://hg.mozilla.org/mozilla-central/rev/3405b354e2f1
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla37
You need to log in before you can comment on or make changes to this bug.