1116758 - "#link_button" refers to 2 elements in the Contacts details DOM

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Johan Lorenzo [:jlorenzo]]

Discovered while writing the test in bug 1086687.

2 buttons shares the same ID (link_button) in the contacts details page. This prevents the page object tests/python/gaia-ui-tests/gaiatest/apps/contacts/regions/contact_details.py from using it: Marionette can't tap on the displayed button.

Comment 1

[Johan Lorenzo [:jlorenzo]]

Would you mind having a look at it, Jose?

Comment 2

[Jose Manuel Cantera]

that's due to the usage of templates. You will have to use another mechanism to get access to that button, for instance using a selector like

#social-template-0 .icon-link

Comment 3

[Johan Lorenzo [:jlorenzo]]

Okay, we use a similar selector for now.

I see one issue here though. I don't see the point of defining ID inside a template (like in the contact details page[1]) if we can't actually use them because they're not unique along the page. Why do we keep them?

[1] https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/elements/details.html#L32-L50

Comment 4

[Jose Manuel Cantera]

(In reply to Johan Lorenzo [:jlorenzo] (QA) from comment #3)
> Okay, we use a similar selector for now.
> 
> I see one issue here though. I don't see the point of defining ID inside a
> template (like in the contact details page[1]) if we can't actually use them
> because they're not unique along the page. Why do we keep them?
> 
> [1]
> https://github.com/mozilla-b2g/gaia/blob/master/apps/communications/contacts/
> elements/details.html#L32-L50

probably we could get rid of ids from templates

Comment 5

[Martijn Wargers (dead)]

It looks like the whole Facebook link/unlink UI has been removed now from Gaia, so I guess this bug can be resolved wfm?
I still see some mentioning of "link_button" here:
http://mxr.mozilla.org/gaia/source/apps/communications/contacts/test/unit/mock_details_dom.js.html?force=1#59
http://mxr.mozilla.org/gaia/source/apps/communications/contacts/test/unit/mock_contacts_index.html?force=1#154
It looks like this is still used in some unit test or something? I guess it can be removed there as well.

Comment 6

[BMO Automation]

Firefox OS is not being worked on