Closed
Bug 1116765
Opened 9 years ago
Closed 9 years ago
browser_noperm.js failing with "Permission indexedDB unknown"
Categories
(Firefox Graveyard :: Webapp Runtime, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 38
People
(Reporter: marco, Assigned: marco)
References
Details
Attachments
(1 file)
1.59 KB,
patch
|
myk
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•9 years ago
|
||
We're getting ALLOW_ACTION instead of UNKNOWN_ACTION for the indexedDB permission. Is this expected? This is the app manifest: { "name": "No Permissions Test Webapp", "description": "A webapp for testing permission installation.", "launch_path": "/webapprtChrome/webapprt/test/chrome/noperm.html" }
Flags: needinfo?(fabrice)
Assignee | ||
Comment 2•9 years ago
|
||
This patch makes the test pass, but it is valid only if the reply to my previous question is "yes".
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → mar.castelluccio
Status: NEW → ASSIGNED
Comment 3•9 years ago
|
||
I don't think getting ALLOW is expected if nothing is declared in the manifest. Could that be a side effect from another test running before this one?
Flags: needinfo?(fabrice)
Assignee | ||
Comment 4•9 years ago
|
||
Looks like we're granting the indexedDB permission to all installed apps: http://mxr.mozilla.org/mozilla-central/source/dom/apps/PermissionsInstaller.jsm#121 So the patch is correct.
Assignee | ||
Updated•9 years ago
|
Attachment #8542974 -
Flags: review?(myk)
Updated•9 years ago
|
Priority: -- → P1
Updated•9 years ago
|
Attachment #8542974 -
Flags: review?(myk) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 5•9 years ago
|
||
can we get a try run for this change ? Thanks
Flags: needinfo?(mar.castelluccio)
Keywords: checkin-needed
Assignee | ||
Comment 6•9 years ago
|
||
This test isn't run on try yet (bug 899707 is tracking enabling webapprt chrome tests)
Flags: needinfo?(mar.castelluccio)
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Comment 7•9 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/7d8cf5a0e17f
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 8•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/7d8cf5a0e17f
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•