Closed Bug 1116765 Opened 5 years ago Closed 5 years ago

browser_noperm.js failing with "Permission indexedDB unknown"

Categories

(Firefox Graveyard :: Webapp Runtime, defect, P1)

x86_64
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 38

People

(Reporter: marco, Assigned: marco)

References

Details

Attachments

(1 file)

No description provided.
We're getting ALLOW_ACTION instead of UNKNOWN_ACTION for the indexedDB permission. Is this expected?

This is the app manifest:
{
  "name": "No Permissions Test Webapp",
  "description": "A webapp for testing permission installation.",
  "launch_path": "/webapprtChrome/webapprt/test/chrome/noperm.html"
}
Flags: needinfo?(fabrice)
Attached patch PatchSplinter Review
This patch makes the test pass, but it is valid only if the reply to my previous question is "yes".
Assignee: nobody → mar.castelluccio
Status: NEW → ASSIGNED
I don't think getting ALLOW is expected if nothing is declared in the manifest. Could that be a side effect from another test running before this one?
Flags: needinfo?(fabrice)
Looks like we're granting the indexedDB permission to all installed apps: http://mxr.mozilla.org/mozilla-central/source/dom/apps/PermissionsInstaller.jsm#121

So the patch is correct.
Attachment #8542974 - Flags: review?(myk)
Priority: -- → P1
Attachment #8542974 - Flags: review?(myk) → review+
Keywords: checkin-needed
can we get a try run for this change ? Thanks
Flags: needinfo?(mar.castelluccio)
Keywords: checkin-needed
This test isn't run on try yet (bug 899707 is tracking enabling webapprt chrome tests)
Flags: needinfo?(mar.castelluccio)
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/7d8cf5a0e17f
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 38
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.