Closed
Bug 1116868
Opened 8 years ago
Closed 8 years ago
Add JNI template classes
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 37
People
(Reporter: jchen, Assigned: jchen)
References
Details
Attachments
(4 files)
6.37 KB,
patch
|
snorp
:
review+
glandium
:
review+
|
Details | Diff | Splinter Review |
17.94 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
5.76 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
8.82 KB,
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
As a precursor to bug 1116589 (Use templated classes in generated JNI bindings), we want to add several new template classes, i.e. * new RAII classes to track JNI references (e.g. LocalRef and GlobalRef classes) * traits classes for different JNI types (e.g. which type corresponds to which JNIEnv call) * accessor classes for making actual JNI calls (e.g. Method, Field, Constructor classes)
Assignee | ||
Comment 1•8 years ago
|
||
Separate out GetJNIForThread and HandleUncaughtException from AndroidBridge to resolve a header dependency issue with the later patches. widget/android/jni will be used for all the new JNI classes.
Attachment #8543308 -
Flags: review?(snorp)
Attachment #8543308 -
Flags: review?(snorp) → review+
Assignee | ||
Comment 2•8 years ago
|
||
Add smart reference classes for JNI.
Attachment #8543386 -
Flags: review?(snorp)
Assignee | ||
Comment 3•8 years ago
|
||
Add JNI type classes used when converting between JNI types and native types.
Attachment #8543387 -
Flags: review?(snorp)
Assignee | ||
Comment 4•8 years ago
|
||
Add template classes that perform JNI operations on methods, constructors, and fields. See attachment 8542691 [details] for an example usage.
Attachment #8543388 -
Flags: review?(snorp)
Comment on attachment 8543386 [details] [diff] [review] Add templated JNI reference classes (v1) Review of attachment 8543386 [details] [diff] [review]: ----------------------------------------------------------------- We talked about these patches a bunch during our 1:1, so I'm gonna r+ based on that.
Attachment #8543386 -
Flags: review?(snorp) → review+
Attachment #8543387 -
Flags: review?(snorp) → review+
Attachment #8543388 -
Flags: review?(snorp) → review+
Assignee | ||
Comment 6•8 years ago
|
||
Comment on attachment 8543308 [details] [diff] [review] Add JNI utility functions (v1) Need a build peer for the moz.build changes (not sure I need to include chromium-config.mozbuild if it's not using IPC?).
Attachment #8543308 -
Flags: review?(mh+mozilla)
Comment 7•8 years ago
|
||
Comment on attachment 8543308 [details] [diff] [review] Add JNI utility functions (v1) Review of attachment 8543308 [details] [diff] [review]: ----------------------------------------------------------------- ::: widget/android/jni/moz.build @@ +13,5 @@ > +] > + > +FAIL_ON_WARNINGS = True > + > +include('/ipc/chromium/chromium-config.mozbuild') You probably don't need this.
Attachment #8543308 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 8•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/69654c281aaa
Comment 9•8 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/69654c281aaa
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
Updated•1 year ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•