1116868 - Add JNI template classes

Status: RESOLVED FIXED

(Firefox for Android :: General, defect)

Description

[(inactive) Jim Chen [:jchen] [:darchons]]

As a precursor to bug 1116589 (Use templated classes in generated JNI bindings), we want to add several new template classes, i.e.

* new RAII classes to track JNI references (e.g. LocalRef and GlobalRef classes)
* traits classes for different JNI types (e.g. which type corresponds to which JNIEnv call)
* accessor classes for making actual JNI calls (e.g. Method, Field, Constructor classes)

Comment 1

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Add JNI utility functions (v1)

Separate out GetJNIForThread and HandleUncaughtException from AndroidBridge to resolve a header dependency issue with the later patches. widget/android/jni will be used for all the new JNI classes.

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Add templated JNI reference classes (v1)

Add smart reference classes for JNI.

Comment 3

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Add JNI type adapter classes (v1)

Add JNI type classes used when converting between JNI types and native types.

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Attachment: Add JNI member accessor classes (v1)

Add template classes that perform JNI operations on methods, constructors, and fields. See attachment 8542691 [details] for an example usage.

Comment 5

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8543386 [details] [diff] [review]
Add templated JNI reference classes (v1)

Review of attachment 8543386 [details] [diff] [review]:
-----------------------------------------------------------------

We talked about these patches a bunch during our 1:1, so I'm gonna r+ based on that.

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8543308 [details] [diff] [review]
Add JNI utility functions (v1)

Need a build peer for the moz.build changes (not sure I need to include chromium-config.mozbuild if it's not using IPC?).

Comment 7

[Mike Hommey [:glandium]]

Comment on attachment 8543308 [details] [diff] [review]
Add JNI utility functions (v1)

Review of attachment 8543308 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/android/jni/moz.build
@@ +13,5 @@
> +]
> +
> +FAIL_ON_WARNINGS = True
> +
> +include('/ipc/chromium/chromium-config.mozbuild')

You probably don't need this.

Comment 8

[(inactive) Jim Chen [:jchen] [:darchons]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/69654c281aaa

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/69654c281aaa