Status

()

defect
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jchen, Assigned: jchen)

Tracking

Trunk
Firefox 37
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

As a precursor to bug 1116589 (Use templated classes in generated JNI bindings), we want to add several new template classes, i.e.

* new RAII classes to track JNI references (e.g. LocalRef and GlobalRef classes)
* traits classes for different JNI types (e.g. which type corresponds to which JNIEnv call)
* accessor classes for making actual JNI calls (e.g. Method, Field, Constructor classes)
Separate out GetJNIForThread and HandleUncaughtException from AndroidBridge to resolve a header dependency issue with the later patches. widget/android/jni will be used for all the new JNI classes.
Attachment #8543308 - Flags: review?(snorp)
Attachment #8543308 - Flags: review?(snorp) → review+
Add smart reference classes for JNI.
Attachment #8543386 - Flags: review?(snorp)
Add JNI type classes used when converting between JNI types and native types.
Attachment #8543387 - Flags: review?(snorp)
Add template classes that perform JNI operations on methods, constructors, and fields. See attachment 8542691 [details] for an example usage.
Attachment #8543388 - Flags: review?(snorp)
Comment on attachment 8543386 [details] [diff] [review]
Add templated JNI reference classes (v1)

Review of attachment 8543386 [details] [diff] [review]:
-----------------------------------------------------------------

We talked about these patches a bunch during our 1:1, so I'm gonna r+ based on that.
Attachment #8543386 - Flags: review?(snorp) → review+
Attachment #8543387 - Flags: review?(snorp) → review+
Attachment #8543388 - Flags: review?(snorp) → review+
Comment on attachment 8543308 [details] [diff] [review]
Add JNI utility functions (v1)

Need a build peer for the moz.build changes (not sure I need to include chromium-config.mozbuild if it's not using IPC?).
Attachment #8543308 - Flags: review?(mh+mozilla)
Comment on attachment 8543308 [details] [diff] [review]
Add JNI utility functions (v1)

Review of attachment 8543308 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/android/jni/moz.build
@@ +13,5 @@
> +]
> +
> +FAIL_ON_WARNINGS = True
> +
> +include('/ipc/chromium/chromium-config.mozbuild')

You probably don't need this.
Attachment #8543308 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/69654c281aaa
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 37
You need to log in before you can comment on or make changes to this bug.